Fixed exception "Cannot read properties of null (reading 'plot')" (#7422

)
cvat-ai · Feb 1, 2024 · 27f8aa7 · 27f8aa7
1 parent b539802
commit 27f8aa7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/changelog.d/20240201_123339_boris_fixed_exception_1.md b/changelog.d/20240201_123339_boris_fixed_exception_1.md
@@ -0,0 +1,4 @@
+### Fixed
+
+- Unhandled exception "Cannot read properties of null (reading 'plot')"
+  (<https://github.com/opencv/cvat/pull/7422>)
diff --git a/cvat-canvas/src/typescript/sliceHandler.ts b/cvat-canvas/src/typescript/sliceHandler.ts
@@ -448,8 +448,13 @@ export class SliceHandlerImpl implements SliceHandler {
                     return;
                 }
 
-                points.push([x, y]);
-                this.slicingLine.plot(stringifyPoints(points.flat()));
+                if (this.enabled) {
+                    // check if slicing is still enabled
+                    // because click() may finish slicing from inside
+                    // e.g. when click out of contour with enabled shift
+                    points.push([x, y]);
+                    this.slicingLine.plot(stringifyPoints(points.flat()));
+                }
             }
         };