Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reblacken Python code #7461

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Reblacken Python code #7461

merged 2 commits into from
Feb 9, 2024

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Feb 8, 2024

Motivation and context

Black 24 is upon us, and with it a new stable code style. Reformat all code to prevent CI failures in future PRs.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Black 24 is upon us, and with it a new stable style. Reformat all code
to prevent CI failures in future PRs.
Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the requirements lists?

I don't think black belongs in either `cvat-sdk/gen/requirements.txt` or
`site/requirements.txt`, so remove it from there.
@SpecLad SpecLad requested a review from mdacoca as a code owner February 8, 2024 18:20
@SpecLad
Copy link
Contributor Author

SpecLad commented Feb 8, 2024

Should we also update the requirements lists?

Sure, done.

(For a couple of those files, I don't think black belongs there at all, so I got rid of it.)

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Merging #7461 (038dae4) into develop (9f517d1) will increase coverage by 0.04%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7461      +/-   ##
===========================================
+ Coverage    83.52%   83.56%   +0.04%     
===========================================
  Files          374      374              
  Lines        39753    39742      -11     
  Branches      3731     3731              
===========================================
+ Hits         33205    33212       +7     
+ Misses        6548     6530      -18     
Components Coverage Δ
cvat-ui 79.48% <ø> (+0.01%) ⬆️
cvat-server 87.33% <100.00%> (+0.06%) ⬆️

@nmanovic nmanovic merged commit b4eed78 into cvat-ai:develop Feb 9, 2024
34 checks passed
@SpecLad SpecLad deleted the reblacken branch September 30, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants