Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup task created from cloud #8972

Merged
merged 16 commits into from
Feb 7, 2025
Merged

Conversation

Eldies
Copy link
Contributor

@Eldies Eldies commented Jan 21, 2025

Motivation and context

Making a backup for tasks/projects created from cloud storage

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Eldies Eldies requested a review from SpecLad as a code owner February 4, 2025 06:53
@zhiltsov-max
Copy link
Contributor

Please update the changelog

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make tests pass successfully.

@Eldies Eldies requested a review from nmanovic as a code owner February 4, 2025 11:39
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.92%. Comparing base (fec040d) to head (cb19edd).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8972      +/-   ##
===========================================
+ Coverage    73.75%   73.92%   +0.17%     
===========================================
  Files          428      428              
  Lines        44514    44529      +15     
  Branches      3881     3881              
===========================================
+ Hits         32830    32918      +88     
+ Misses       11684    11611      -73     
Components Coverage Δ
cvat-ui 77.46% <ø> (-0.01%) ⬇️
cvat-server 71.00% <100.00%> (+0.32%) ⬆️

@Eldies
Copy link
Contributor Author

Eldies commented Feb 6, 2025

Please update the changelog

Done.
Also, all tests are green

elif self._db_data.storage == StorageChoice.CLOUD_STORAGE:
assert self._db_task.dimension != models.DimensionType.DIM_3D, "Cloud storage cannot contain 3d images"
assert not hasattr(self._db_data, 'video'), "Only images can be stored in cloud storage"
assert self._db_data.related_files.count() == 0, "No related images can be stored in cloud storage"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: #9071

Copy link

sonarqubecloud bot commented Feb 7, 2025

@zhiltsov-max zhiltsov-max merged commit c25ab4b into develop Feb 7, 2025
34 checks passed
@zhiltsov-max zhiltsov-max deleted the dl/backup-task-from-cloud branch February 7, 2025 12:26
@cvat-bot cvat-bot bot mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants