Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated minimal object size limitation #9055

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Updated minimal object size limitation #9055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d4dd1c
Updated minimal object size limitation
bsekachev Feb 5, 2025
8e4bd96
Update 20250205_122237_sekachev.bs_small_objects_limit.md
bsekachev Feb 5, 2025
c40e9a2
Update 20250205_122237_sekachev.bs_small_objects_limit.md
bsekachev Feb 5, 2025
97cc505
Slightly refactored
bsekachev Feb 5, 2025
497eabc
Slightly refactored
bsekachev Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.d/20250205_122237_sekachev.bs_small_objects_limit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
### Changed

- Updated limitation for minimal object size from 9px area to 1px in dimensions
(<https://github.com/cvat-ai/cvat/pull/9055>)
57 changes: 30 additions & 27 deletions cvat-core/src/object-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,45 +67,48 @@ export function findAngleDiff(rightAngle: number, leftAngle: number): number {
}

export function checkShapeArea(shapeType: ShapeType, points: number[]): boolean {
const MIN_SHAPE_LENGTH = 3;
const MIN_SHAPE_AREA = 9;
const MIN_MASK_SHAPE_AREA = 1;
const MIN_SHAPE_SIZE = 1;

if (shapeType === ShapeType.POINTS) {
return true;
}

let width = 0;
let height = 0;

if (shapeType === ShapeType.MASK) {
const [left, top, right, bottom] = points.slice(-4);
const area = (right - left + 1) * (bottom - top + 1);
return area >= MIN_MASK_SHAPE_AREA;
}

if (shapeType === ShapeType.ELLIPSE) {
[width, height] = [right - left + 1, bottom - top + 1];
} else if (shapeType === ShapeType.RECTANGLE) {
const [xtl, ytl, xbr, ybr] = points;
[width, height] = [xbr - xtl, ybr - ytl];
} else if (shapeType === ShapeType.ELLIPSE) {
const [cx, cy, rightX, topY] = points;
const [rx, ry] = [rightX - cx, cy - topY];
return rx * ry * Math.PI > MIN_SHAPE_AREA;
}

let xmin = Number.MAX_SAFE_INTEGER;
let xmax = Number.MIN_SAFE_INTEGER;
let ymin = Number.MAX_SAFE_INTEGER;
let ymax = Number.MIN_SAFE_INTEGER;
[width, height] = [(rightX - cx) * 2, (cy - topY) * 2];
} else {
// polygon, polyline, cuboid, skeleton
let xmin = Number.MAX_SAFE_INTEGER;
let xmax = Number.MIN_SAFE_INTEGER;
let ymin = Number.MAX_SAFE_INTEGER;
let ymax = Number.MIN_SAFE_INTEGER;

for (let i = 0; i < points.length - 1; i += 2) {
xmin = Math.min(xmin, points[i]);
xmax = Math.max(xmax, points[i]);
ymin = Math.min(ymin, points[i + 1]);
ymax = Math.max(ymax, points[i + 1]);
}

for (let i = 0; i < points.length - 1; i += 2) {
xmin = Math.min(xmin, points[i]);
xmax = Math.max(xmax, points[i]);
ymin = Math.min(ymin, points[i + 1]);
ymax = Math.max(ymax, points[i + 1]);
}
if (shapeType === ShapeType.POLYLINE) {
// horizontal / vertical lines have one of dimensions equal to zero
const length = Math.max(xmax - xmin, ymax - ymin);
return length >= MIN_SHAPE_SIZE;
}

if (shapeType === ShapeType.POLYLINE) {
const length = Math.max(xmax - xmin, ymax - ymin);
return length >= MIN_SHAPE_LENGTH;
[width, height] = [xmax - xmin, ymax - ymin];
}

const area = (xmax - xmin) * (ymax - ymin);
return area >= MIN_SHAPE_AREA;
return width >= MIN_SHAPE_SIZE && height >= MIN_SHAPE_SIZE;
}

export function rotatePoint(x: number, y: number, angle: number, cx = 0, cy = 0): number[] {
Expand Down
Loading