Fix track interpolation in tasks with deleted frames #9059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiltsov-max
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9059 +/- ##
==========================================
Coverage ? 73.74%
==========================================
Files ? 428
Lines ? 44515
Branches ? 3881
==========================================
Hits ? 32828
Misses ? 11687
Partials ? 0
|
zhiltsov-max
changed the title
Marishka17
reviewed
Feb 7, 2025
| @@ -1307,8 +1308,9 @@ def get_frame(task_id: int, idx: int) -> ProjectData.Frame: | |||
| anno_manager.to_shapes( | |||
| task.data.size, | |||
| included_frames=task_included_frames, | |||
| deleted_frames=set(f for t_id, f in self.deleted_frames if t_id == task.id), | |||
There was a problem hiding this comment.
why not task_data.deleted_frames.keys()?
There was a problem hiding this comment.
This is the same. But there is an extra check below, which can be removed now.
|
Marishka17
approved these changes
Feb 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Follow-up for #8834.
If a task or a job contains deleted frames that contain track keyframes, these keyframes should be excluded from the interpolation. However, in jobs having specific frames included (e.g. GT jobs), deleted frames should not be confused with included frames during track interpolation. Deleted frames should affect existing shapes in tracks, while included frames should only filter the resulting annotations after interpolation. This PR implements this approach.
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.