Add attribute support for auto-annotation functions #9090
+954
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
force-pushed
the
aa-attributes
branch
2 times, most recently
from
1a2b7ff to
2cb88b3
Compare
SpecLad
force-pushed
the
aa-attributes
branch
from
2cb88b3 to
6681b9b
Compare
|
SpecLad
requested review from
zhiltsov-max,
bsekachev and
nmanovic
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9090 +/- ##
===========================================
- Coverage 73.91% 73.79% -0.12%
===========================================
Files 428 429 +1
Lines 44530 44674 +144
Branches 3881 3881
===========================================
+ Hits 32915 32969 +54
- Misses 11615 11705 +90
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Remove one of the long-standing limitations on auto-annotation functions by adding the necessary validation and remapping logic to support attribute specifications and values. Add a utility module for attributes with functionality I needed, but felt didn't belong in the auto-annotation layer.
Adds the necessary code to support using functions with attributes via agents, as well. I will submit the necesssary server-side code will be submitted to the private repository later; until that is merged, attempts to create native functions with attributes will be rejected.
How has this been tested?
Unit tests and manual testing.
Checklist
developbranch[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.