Project quality #9116
Open
Project quality #9116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject-quality-v2
Marishka17
reviewed
Mar 28, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "job__segment__task", | ||
| "job__segment__task__project", | ||
| "task", | ||
| "task__project", |
Check warning
Code scanning / CodeQL
Information exposure through an exception
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 10 hours ago
To fix the problem, we should ensure that the exception message does not expose any sensitive information to the end user. Instead of directly converting the exception to a string and raising it, we should log the detailed exception message on the server and return a generic error message to the user.
- Modify the code to log the exception message using a logging framework.
- Raise a
ValidationErrorwith a generic error message that does not reveal internal details.
Suggested changeset
1
cvat/apps/quality_control/views.py
| @@ -5,3 +5,3 @@ | ||
| import textwrap | ||
|
|
||
| import logging | ||
| from django.db.models import Q, QuerySet | ||
| @@ -49,3 +49,3 @@ | ||
|
|
||
|
|
||
| logger = logging.getLogger(__name__) | ||
| @extend_schema(tags=["quality"]) | ||
| @@ -349,3 +349,4 @@ | ||
| except qc.QualityReportManager.QualityReportsNotAvailable as ex: | ||
| raise ValidationError(str(ex)) | ||
| logger.error(f"QualityReportsNotAvailable exception: {str(ex)}") | ||
| raise ValidationError("Quality reports are currently not available. Please try again later.") | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Obsoletes #6367
Depends on: #9275, #9272
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.