Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asctime to uvicorn stdout logs #9210

Merged
merged 4 commits into from
Mar 21, 2025

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Mar 13, 2025

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Marishka17 Marishka17 marked this pull request as ready for review March 14, 2025 09:59
@Marishka17 Marishka17 requested a review from SpecLad as a code owner March 14, 2025 09:59
@Marishka17
Copy link
Contributor Author

Marishka17 commented Mar 14, 2025

I'm not sure whether it is better to keep the logging config in django settings (one place with all configs) or provide a log config file by passing the --log-config option when running uvicorn.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.14%. Comparing base (17bb612) to head (03456e2).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9210   +/-   ##
========================================
  Coverage    74.14%   74.14%           
========================================
  Files          428      428           
  Lines        44973    44973           
  Branches      3917     3917           
========================================
  Hits         33345    33345           
  Misses       11628    11628           
Components Coverage Δ
cvat-ui 77.22% <ø> (ø)
cvat-server 71.58% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marishka17 Marishka17 requested review from azhavoro and removed request for SpecLad March 14, 2025 12:33
@SpecLad
Copy link
Contributor

SpecLad commented Mar 14, 2025

Could you explain why you want to do this? Supervisor already adds the time.

@Marishka17
Copy link
Contributor Author

Marishka17 commented Mar 14, 2025

Could you explain why you want to do this? Supervisor already adds the time.

just go to a container and check uvicorn logs in /tmp dir
@SpecLad, does this answer your question?

@SpecLad
Copy link
Contributor

SpecLad commented Mar 19, 2025

Could you add a changelog entry?

@Marishka17 Marishka17 requested a review from nmanovic as a code owner March 21, 2025 09:10
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@SpecLad SpecLad merged commit 4133653 into develop Mar 21, 2025
34 checks passed
@SpecLad SpecLad deleted the mk/add_timestamp_to_uvicorn_stdout_logs branch March 21, 2025 10:08
@cvat-bot cvat-bot bot mentioned this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants