Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated some deprecated functions calls #450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated some deprecated functions calls #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hloc/localize_sfm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def __init__(self, reconstruction, config=None):
def localize(self, points2D_all, points2D_idxs, points3D_id, query_camera):
points2D = points2D_all[points2D_idxs]
points3D = [self.reconstruction.points3D[j].xyz for j in points3D_id]
ret = pycolmap.absolute_pose_estimation(
ret = pycolmap.estimate_and_refine_absolute_pose(
points2D,
points3D,
query_camera,
Expand Down
2 changes: 1 addition & 1 deletion hloc/visualization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def visualize_loc_from_log(
# select the first, largest cluster if the localization failed
loc = loc["log_clusters"][loc["best_cluster"] or 0]

inliers = np.array(loc["PnP_ret"]["inliers"])
inliers = np.array(loc["PnP_ret"]["inlier_mask"])
mkp_q = loc["keypoints_query"]
n = len(loc["db"])
if reconstruction is not None:
Expand Down
Loading