Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select reconstruction from folder outputs #455

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions hloc/reconstruction.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,23 +84,32 @@ def run_reconstruction(
return None
logger.info(f"Reconstructed {len(reconstructions)} model(s).")

largest_index = None
largest_folder = None
largest_num_images = 0
for index, rec in reconstructions.items():
num_images = rec.num_reg_images()
if num_images > largest_num_images:
largest_index = index
largest_num_images = num_images
assert largest_index is not None
for model_dir in models_path.iterdir():
if not model_dir.is_dir():
continue
try:
rec = pycolmap.Reconstruction(model_dir)
num_images = rec.num_reg_images()
if num_images > largest_num_images:
largest_folder = model_dir
largest_num_images = num_images
except Exception as e:
logger.warning(f"Could not load reconstruction from {model_dir}: {e}")
continue
assert largest_folder is not None

logger.info(
f"Largest model is #{largest_index} " f"with {largest_num_images} images."
f"Largest model is {largest_folder.name} " f"with {largest_num_images} images."
)

for filename in ["images.bin", "cameras.bin", "points3D.bin"]:
if (sfm_dir / filename).exists():
(sfm_dir / filename).unlink()
shutil.move(str(models_path / str(largest_index) / filename), str(sfm_dir))
return reconstructions[largest_index]
shutil.move(str(largest_folder / filename), str(sfm_dir))

return pycolmap.Reconstruction(sfm_dir)


def main(
Expand Down