Skip to content

Adapt to the new interface for pycolmap 3.12 - #467

Merged
Phil26AT merged 25 commits into
masterfrom
features/fix_pycolmap
Jul 22, 2025
Merged

Adapt to the new interface for pycolmap 3.12#467
Phil26AT merged 25 commits into
masterfrom
features/fix_pycolmap

Conversation

@B1ueber2y

@B1ueber2y B1ueber2y commented Jul 4, 2025

Copy link
Copy Markdown
Member

Reopening #446 from the official repo.

Fixes #460
Fixes #445
Fixes #440
Fixes #438

@ayoussf

ayoussf commented Jul 4, 2025

Copy link
Copy Markdown

Hello,

I wanted to note that you need to set the following line to
poses[q] = (ret["cam_from_world"].rotation.quat[[3, 0, 1, 2]], ret["cam_from_world"].translation)

As pycolmap no longer supports the original line.

@Phil26AT

Phil26AT commented Jul 4, 2025

Copy link
Copy Markdown
Collaborator

With the latest updates the Aachen evaluation works again

@Phil26AT

Copy link
Copy Markdown
Collaborator

I can also confirm that the InLoc pipeline works again.

@Phil26AT
Phil26AT requested a review from sarlinpe July 21, 2025 08:30

@sarlinpe sarlinpe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the work!

About the notebook: there is an empty cell at the end, can you remove it? The notebook is also much larger than the previous one (9MB vs 2MB), can we reduce it?

Comment thread hloc/localize_inloc.py Outdated
Comment thread hloc/pipelines/7Scenes/create_gt_sfm.py Outdated
Comment thread hloc/pipelines/7Scenes/create_gt_sfm.py Outdated
Comment thread hloc/reconstruction.py
Comment thread hloc/reconstruction.py Outdated
@Phil26AT

Copy link
Copy Markdown
Collaborator

Thank you very much for the work!

About the notebook: there is an empty cell at the end, can you remove it? The notebook is also much larger than the previous one (9MB vs 2MB), can we reduce it?

Fixed this, the plotly visualizations were still in the output. Now we are back to 2MB. Side-note: I also changed the default extractor to ALIKED.

@sarlinpe sarlinpe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge!

@B1ueber2y

Copy link
Copy Markdown
Member Author

Thank you so much! @Phil26AT

@Phil26AT
Phil26AT merged commit 2e2a551 into master Jul 22, 2025
1 check passed
@Phil26AT
Phil26AT deleted the features/fix_pycolmap branch July 22, 2025 16:02
This was referenced Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants