Merged
Conversation
Collaborator
Author
|
The error was occurring because make_polynomial_matrix() expects degrees to be an array/list of polynomial degrees, but it was receiving a single integer value. This was happening because maxpolydeg was being handled as a single integer rather than an array of degrees. We've modified the make_polynomial_matrix function to handle both cases:
This change should fix the TypeError while maintaining the intended functionality. The function will now:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes that address the following issues:
Also, reverting changes that were made in this pull request:
We have verified that these changes allow the example01.ipynb script to run correctly. We will continue testing to be sure that this issue is fully resolved across all the latest versions of numpy/python.