Repository navigation
Add test_rhr: app's measured resting HR alongside daily rhr aggregate - #56
Merged
Merged
Conversation
…ggregate The /analyse/dayDetail/query response carries two resting-HR fields: rhr (daily aggregate shown in the web dashboard) and testRhr (measured value the Coros app displays). The parser previously dropped testRhr, so the MCP data could not be matched 1:1 against the app. DailyRecord now stores both; the get_daily_metrics tool description documents the semantics and recommends test_rhr for app comparisons. Cached days from before this change have test_rhr null until re-synced. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/analyse/dayDetail/queryresponse carries two resting-HR fields:rhr(daily aggregate, web dashboard value) andtestRhr(measured resting HR — the value the Coros app displays). The parser droppedtestRhr, so MCP data could not be matched 1:1 against the app (verified live: app showed 49/52,rhrwas 56/46).DailyRecordnow stores both (rhr,test_rhr);_parse_daily_record()picks uptestRhr.get_daily_metricstool description documents both fields and recommendstest_rhrfor app comparisons; CLAUDE.md gets a matching section.test_rhr: nulluntil their range is re-synced.Verification
testRhr→None, JSON round-trip); full suite 228 passed, ruff + mypy clean.test_rhr= 51/50/52/49 for Aug 10–13, matching the app exactly.🤖 Generated with Claude Code