feat: add pnpm-version parameter to install command and run job - #592
Open
esetnik wants to merge 1 commit into
Open
feat: add pnpm-version parameter to install command and run job#592esetnik wants to merge 1 commit into
esetnik wants to merge 1 commit into
Conversation
When package-manager is set to pnpm, the orb runs node/install with install-pnpm: true and no version, so the node orb resolves the latest pnpm release (via jsdelivr) and runs npm install -g pnpm@<latest>. Behind registry proxies or version-filtering firewalls (Artifactory, Verdaccio, release-age policies), the freshly released version may not be resolvable from the npm registry yet, failing the install with ETARGET: No matching version found for pnpm@<latest>. Add a pnpm-version parameter to the install command and the run job, threaded through to node/install (which already supports pnpm-version), so users can pin the pnpm version. Defaults to the current behavior of installing the latest stable release. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011RtNiB1ZDoFcd7oBBJFM8C
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When package-manager is set to pnpm, the orb runs node/install with install-pnpm: true and no version, so the node orb resolves the latest pnpm release (via jsdelivr) and runs npm install -g pnpm@. Behind registry proxies or version-filtering firewalls (Artifactory, Verdaccio, release-age policies), the freshly released version may not be resolvable from the npm registry yet, failing the install with ETARGET: No matching version found for pnpm@.
Add a pnpm-version parameter to the install command and the run job, threaded through to node/install (which already supports pnpm-version), so users can pin the pnpm version. Defaults to the current behavior of installing the latest stable release.
Claude-Session: https://claude.ai/code/session_011RtNiB1ZDoFcd7oBBJFM8C