Bypass perfomance issues through sending Strings instead of Objects #89
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for cypress-io#26
|
|
|
Hey, can you get this resolved and merged in? I do confirm this fixes the problem for me but i cannot use forked Cypress so do need to wait for official patch. When can we get this released? |
|
Never mind, thanks for patching it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #26 and #76.
Since the circular-json detecion implemented here cypress-io/cypress#4407 the combine coverage slows down or even breaks the tests in big projects.
By stringify the Json we can bypass the performance issues for most cases. I'm not sure how it behaves when even
JSON.stringfyslows down but even then it should be better than the circular-json chekcup.