Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Node.js 18/23 removal #6138

Open
wants to merge 4 commits into
base: release/15.0.0
Choose a base branch
from

Conversation

jennifer-shehane
Copy link
Member

Copy link

cypress bot commented Mar 31, 2025

cypress-documentation    Run #379

Run Properties:  status check passed Passed #379  •  git commit c9eb7a3209: Merge branch 'release/15.0.0' into node-18-23-removal
Project cypress-documentation
Branch Review node-18-23-removal
Run status status check passed Passed #379
Run duration 08m 15s
Commit git commit c9eb7a3209: Merge branch 'release/15.0.0' into node-18-23-removal
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 301
View all changes introduced in this branch ↗︎
UI Coverage  10.95%
  Untested elements 2393  
  Tested elements 3  
Accessibility  96.89%
  Failed rules  1 critical   4 serious   4 moderate   0 minor
  Failed elements 27  

@MikeMcC399
Copy link
Contributor

If Node.js 18.x will no longer be supported. Node.js 20.x LTS becomes the lowest supported version.

The lowest 20.x LTS version is Node.js v20.9.0 which ships with npm 10.1.0. So this means that the npm version should be bumped from 8.6.0 to 10.1.0 to match.

| [npm](https://docs.npmjs.com/) | `8.6.0` and above | [Downloading and installing Node.js and npm](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm) |

(Node.js v20.0.0 shipped with npm 9.6.4 but I don't think this needs to be considered because Node.js doesn't support older non-LTS releases.)

@jennifer-shehane
Copy link
Member Author

@MikeMcC399 Thanks for the detailed review, as always! I updated the lowest npm version supported as well.

@jennifer-shehane jennifer-shehane changed the base branch from main to release/15.0.0 April 7, 2025 14:18
@MikeMcC399
Copy link
Contributor

@jennifer-shehane

Thanks for the detailed review, as always! I updated the lowest npm version supported as well.

Thanks also for making the tweak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants