fix: remove 'new' badge from Create from Component, fix parsing #31457
Conversation
| @@ -33,6 +33,7 @@ export class CodegenActions { | |||
| let result = parseReactComponent(src, { | |||
| resolver: findAllWithLink(exportResolver, reactDocgenResolvers), | |||
| babelOptions: { | |||
| configFile: false, | |||
There was a problem hiding this comment.
This option disables the use of a config file for Babel. this is what we want since we're calling it directly, we don't want to pick up any config file that might be in the project
There was a problem hiding this comment.
is it possible to add a test for this?
There was a problem hiding this comment.
@AtofStryker I added a test in CodegenActions.spec.ts just to make sure that we pass this option to Babel. I went down the road of trying to do a system test for this instead, but couldn't get it to work
There was a problem hiding this comment.
its probably hard to do a system test since its code generation for a component? Have you tried a cy-in-cy test? That would give us the most coverage here
There was a problem hiding this comment.
@astone123 any luck with the cy-in-cy test?
There was a problem hiding this comment.
no I haven't looked at it yet, will try it out this week
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
create-from-component-fix
|
| Run status |
|
| Run duration | 18m 25s |
| Commit |
|
| Committer | Adam Stone-Lord |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
8
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32128
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.31%
|
|
|---|---|
|
Untested elements
|
184
|
|
Tested elements
|
163
|
Accessibility
92.59%
|
|
|---|---|
|
Failed rules
|
3 critical
7 serious
2 moderate
1 minor
|
|
Failed elements
|
885
|
Tests for review
src/components/StandardModal.cy.tsx • 1 failed test • frontend-shared-ct
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when route is never resolved |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > stops waiting when an xhr request is canceled |
The first 5 flaky specs are shown, see all 8 specs in Cypress Cloud. | |
| @@ -33,6 +33,7 @@ export class CodegenActions { | |||
| let result = parseReactComponent(src, { | |||
| resolver: findAllWithLink(exportResolver, reactDocgenResolvers), | |||
| babelOptions: { | |||
| configFile: false, | |||
There was a problem hiding this comment.
is it possible to add a test for this?
Additional details
This PR removes the "New" badge for the Create from Component feature - we released it over two years ago. It also fixes an issue where we would fail to parse component files for certain projects that had babel configurations in their project root. You can see this issue with
cypress-servicesdashboard tests - if you try to use Create from Component with any of these files, it will error on all of them because of Babel plugin issues from the project's Babel config. We don't want to use the project's configuration file.Steps to test
On develop
cypress-services/frontend/packages/dashboardin CTPR Tasks
cypress-documentation?type definitions?