misc: throw error when chrome 137 branded is used with @cypress/puppeteer or --load-extension
#31709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
misc/throw_error_on_extension_chrome_137
|
| Run status |
|
| Run duration | 09m 49s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
694
|
Skipped
|
0
|
Passing
|
130
|
| View all changes introduced in this branch ↗︎ | |
AtofStryker
force-pushed
the
misc/throw_error_on_extension_chrome_137
branch
2 times, most recently
from
748fcdd to
17d43a6
Compare
|
So, if I'm understanding this properly..... Cypress will no longer support Google Chrome (in headed mode) and just error out and not actually run the tests? |
jennifer-shehane
requested changes
May 14, 2025
npm/puppeteer/README.md
Outdated
| @@ -46,6 +46,8 @@ Add the following in `tsconfig.json`: | |||
|
|
|||
| Only Chromium-based browsers (e.g. Chrome, Chromium, Electron) are supported. | |||
|
|
|||
| As of Chrome 137, the `@cypress/puppeteer` plugin will not work in `cypress open` mode (or headed `run` mode) with official branded versions of Chrome (`stable`, `beta`, `dev`, and `canary`). If you need to run the `@cypress/puppeteer` in `cypress open` mode, you will need to use [Chrome for Testing](https://developer.chrome.com/blog/chrome-for-testing), Chromium, or another Chrome variant that supports loading web extensions. The plugin will work as expected in `cypress run` mode in any version of Chrome. | |||
There was a problem hiding this comment.
I already merged a PR for this doc update, so you need to pull in develop.
|
@alexsch01 We will only error if you are using the |
AtofStryker
force-pushed
the
misc/throw_error_on_extension_chrome_137
branch
6 times, most recently
from
75f6190 to
d98bad5
Compare
AtofStryker
changed the title
@cypress/puppeteer or --load-extension@cypress/puppeteer or --load-extension
AtofStryker
force-pushed
the
misc/throw_error_on_extension_chrome_137
branch
from
d98bad5 to
4864c12
Compare
AtofStryker
force-pushed
the
misc/throw_error_on_extension_chrome_137
branch
2 times, most recently
from
91abfc2 to
37835e0
Compare
…uppeteeris used in headed mode or if --load-extension is added to launch options via a user testing an extension empty commit to run ci
AtofStryker
force-pushed
the
misc/throw_error_on_extension_chrome_137
branch
from
37835e0 to
ff5fbb8
Compare
jennifer-shehane
approved these changes
May 15, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--load-extensionusage with Chrome 137+ branded builds #31702@cypress/puppeteerplugin to warn users about Chrome 137+ branded builds #31703Additional details
With the release of Chrome v137, the
--load-extensionlaunch argument will no longer be supported in branded versions of chrome. This impacts the@cypress/puppeteerplugin and users leveraging launchOptions.extensions to add extensions to Chrome. If users need to leverage these options, please use Chrome for Testing, Chromium, or another Chrome variant that supports loading extensions.To mitigate this, Cypress will now print a warning if branded chrome 137 and up is detected and the
--load-extensionargument is passed in by a user. Additionally,@cypress/puppeteerwill also error if branded chrome 137 and up is detected.Steps to test
TODO: test the binary and verify functionality. Add unit tests and system tests that leverage the plugin
How has the user experience changed?
PR Tasks
cypress-documentation? Update limitations for loading extensions within Cypress cypress-documentation#6183type definitions?