test(launchpad): fix Windows flake in detects CT project framework spec - #34191
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(launchpad): fix Windows flake in detects CT project framework spec#34191cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
The detects CT project framework test called wizard.initialize without awaiting the async detection work. On slower Windows CI runners the default 4s timeout expired before the bundler selector rendered. Await initialize completion and wait for framework detection before asserting on the bundler UI, with longer timeouts consistent with other launchpad e2e specs. Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com>
Collaborator
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Same flake on develop ec97bf1 (pipeline 83371)
PIN_SHA: ec97bf1ade862697a2d673738f4b02c9519fdd66
Merged PR: #34108 — fix: scroll elements into view on both axes during actionability
Pipeline: https://app.circleci.com/pipelines/gh/cypress-io/cypress/83371
Failed job
windows-run-launchpad-integration-tests-chrome (windows workflow → failing)
Root cause (same as this PR)
open-mode.cy.ts → "detects CT project framework"
AssertionError: Timed out retrying after 4000ms: Expected to find element: `[data-testid="select-bundler"]`, but never found it.
at Context.eval (webpack://@packages/launchpad/./cypress/e2e/open-mode.cy.ts:174:9)
Workflow status
| Workflow | Status |
|---|---|
| setup-workflow | ✅ success |
| linux-x64 | ✅ success (ready-to-release ✅) |
| linux-arm64 | ✅ success |
| darwin-x64 | ✅ success |
| darwin-arm64 | ✅ success |
| windows | ❌ failing |
All other platform workflows passed; only the known Windows launchpad flake blocked this pipeline.
Sent by Cursor Automation: Monitor cypress/develop for regressions/flake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
Pipeline 83359 for develop commit
4dfb9bb(#34126) passedready-to-releaseon linux-x64 but the windows workflow failed inwindows-run-launchpad-integration-tests-chrome.Root cause:
open-mode.cy.ts→ "detects CT project framework" calledwizard.initializevia sinon stubwrappedMethod.apply()without awaiting the async framework detection. On slower Windows runners the default 4s timeout expired before[data-testid="select-bundler"]rendered.Fix:
awaitwizard initialization completionSteps to test
yarn workspace @packages/launchpad cypress:run:e2e -- --spec cypress/e2e/open-mode.cy.tsHow has the user experience changed?
No change
PR Tasks