Electron v5.0.10

[chrisbreiding]

Electron 5.0.10, Node 12, Chrome 73

• Closes Large XHR response objects can exceed the maximum header size. #76
• Closes Upgrade to the latest version of Electron #3568
• Closes Bundled Node Version 8.2 is too old #2253
• Closes ECC SSL Certificates not supported #4368
• Closes write EPROTO: SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure when visiting https site #4394
• Closes Cookies are not sent using fetch from electron client #4433
• Closes Electron v5.0.10 #4720
• Closes Fix bug where Chrome policy warnings are not active #4986
• Closes Using apollo-client breaks the tests when run with electron #5044

Changelog

• Updated internal Node.js version to v12.0.0. Fixes Bundled Node Version 8.2 is too old #2253.
  • Fixes a bug where some HTTPS sites failed to load with a "handshake failed" error. Fixes write EPROTO: SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure when visiting https site #4394
• Updated internal Electron version to v5.0.10. Fixes Electron v5.0.10 #4720, Cookies are not sent using fetch from electron client #4433
• Updated internal Chromium version to 73.0.3683.121. Fixes Using apollo-client breaks the tests when run with electron #5044
• Changed the way cookies are set in cy.visit() to be closer to a browser's actual behavior.
• Fixed a bug where the Chrome policy warnings introduced by Warn when ProxyMode/ExtensionWhiteList registry setting is detected #4391 would not appear. Fixes Fix bug where Chrome policy warnings are not active #4986
• Bumped up maximum header size from 80kb to 1mb. Fixes Large XHR response objects can exceed the maximum header size. #76.

[flotwig]

Tasks:

• Changes in Desktop GUI layout issues/improvements #4905 are breaking some desktop-gui tests w Chrome 76: https://stackoverflow.com/a/29909047/3474615
• I was able to get the 2_cookies e2e test working, but had to bump Electron to v5.x (Node 12.0.0) to access the necessary CDP functions. This actually made fewer test suites fail than Electron v3 did, so hopefully it will lessen the redundant work needed for this.
  • cookies are being set incorrectly via CDP, check 5_subdomain_spec e2e test for last failing test
  • Changed the way cookies are set in cy.visit() to be closer to a browser's actual behavior.
    • Failing: 4_request_spec
  • See how Chrome orders the cookies, beyond just expiration ascending
    • https://cs.chromium.org/chromium/src/services/network/public/mojom/cookie_manager.mojom?l=223-225&rcl=97f8d3cc1b46e4fe14b28f40ddabf273c2c8d005
    • first by path length, then by creation date
    • we don't always have access to creation date, so to keep this the same between browsers, just order by expiration ascending
• Deferred issues with page loading in Electron 6 - [WIP] Electron 6.0.10 #5193
• check native deps still work
  • only one is registry-js, manually verified that it's still working
  • get rid of our own registry-js since we can use mainline now
• enable electron promise deprecation warnings in development
  • remove deprecated invocations - removed all i could find
• websockets_spec shows some issues with websocket proxying in Node 12.
  • Works in Node 10.9.0 - broken in Node 10.10.0
  • Node made updates in 10.10.0 that changed how readable streams flow: Flow problem with node >= 10.10 juliangruber/multipipe#48
  • More info: stream: adding new 'data' handler doesn't resume stream after removing 'readable' handler nodejs/node#24474 (comment)
  • Fix for TooTallNate's https-proxy-agent: Fix compatibility with Node.js >= 10.0.0 TooTallNate/proxy-agents#73
  • Fix may also apply to our own agent, but has not been applied yet
    • I believe that this only applies if we're using the readable event - we aren't so it doesn't
• re-write socket_spec - it's failing since Node 10 and i have no idea why, it's always been spurious, might as well re-write it and eliminate the flakiness as we go
  • this was mostly fixed by the websocket_spec fix detailed below
• video recording in e2e tests is busted - this is making most snapshots fail because the end bit is missing. this seems to be because the electron process is exiting before the video can be encoded, not because of an actual bug with video recording (race condition here?)
  • works in Electron 4.2.8 (Node 10.11.0, Chrome 69.0.3497.128) - broken in Electron 5.0.0 (Node 12.0.0, Chrome 73.0.3683.119)
  • could be a bug with a dependency, or a bug in the module API
  • "invalid data found" in uncompressed stream while compressing:

   cypress:server:video compression stderr log { message: '[mov,mp4,m4a,3gp,3g2,mj2 @ 0x70f4cc0] moov atom not found' } +3ms
     cypress:server:video compression stderr log { message: '/home/person/cypress/packages/server/.projects/e2e/cypress/videos/video_compression_spec.coffee.mp4: ' + 'Invalid data found when processing input' } +0ms
  

  • might be easiest just to use CDP video recording Connect to Chrome Remote Interface when launching Chrome and record video #4628
    • tried this and it didn't work either, could be pointing to a change in how Node handles streams
  • tried running normal e2e test, using .jpegs instead of Electron's frames, same issue - probably not a change in how Electron produces frames
  • found it: in Electron 5, Electron started automatically exiting the app once all BrowserWindows were closed. We can fix this by just attaching a noop to the window-all-closed event: https://electronjs.org/docs/api/app#event-window-all-closed
• potentially update proxy to pass 102, 103 codes correctly. Node.js changed in v10 to handle these codes differently: Process 100, 102-199 status codes according to specs. nodejs/node#18033
  • tests that 102 and 103 status codes immediately end the connection have been removed, since in reality these indicate that future data is incoming on the connection
• Node 12 made the max headers size only 8kb, down from 80kb: When http header size limit is reached, instead of a generic 400 response, return 431 Request Header Fields Too Large nodejs/node#25528
  • They also added a --max-http-header-size flag: cli: add --max-http-header-size flag nodejs/node#24811
  • Gives us a chance to finally fix Large XHR response objects can exceed the maximum header size. #76
• Updated websocket errors to not send back a 502, just end the socket. This was broken in Node 12, this new behavior fits in better with how we want to treat network errors anyways:

  • cypress/packages/server/lib/server.coffee

    Lines 638 to 651 in 26c701a

    	onProxyErr = (err, req, res) ->
    	## by default http-proxy will call socket.end
    	## with no data, so we need to override the end
    	## function and write our own response
    	## https://github.com/nodejitsu/node-http-proxy/blob/master/lib/http-proxy/passes/ws-incoming.js#L159
    	end = socket.end
    	socket.end = ->
    	socket.end = end
    	debug(
    	"Got ERROR proxying websocket connection to url: received error %o", { err },
    	)
    	socket.end()

• can now use console.table
• update node versions, docker images to node 12.4.0

[brian-mann]

Ignore socket_spec - it's likely all tested via the e2e tests actually "working".

[cypress-bot]

Released in 3.5.0.