fix(sinon-chai): Added once commands for sinon methods

[sainthkh]

Related to cypress-io/cypress#9644

[Andarist]

I was wondering - shouldnt this report an error based on a failed criteria? The user wont easily know now if the function has been called more than once or if it has been called with wrong arguments

[sainthkh]

I manually tested them. Users can know if a function is called more than once or with wrong arguments.

• Called more than once:

Code:

it('t', () => {
  const foo = cy.spy().as('foo')

  setTimeout(() => {
    foo({ bar: 'test' })
    foo({ bar: 'test' })
  }, 500)

  cy.get('@foo').should(
    'be.calledOnceWith',
    Cypress.sinon.match({
      bar: 'test',
    }),
  )
})

Result:

• Wrong arguments:

Code:

it('t', () => {
  const foo = cy.spy().as('foo')

  setTimeout(() => {
    foo({ bar: 'testing' })
  }, 500)

  cy.get('@foo').should(
    'be.calledOnceWith',
    Cypress.sinon.match({
      bar: 'test',
    }),
  )
})

Result:

[Andarist]

Ok, this addresses my concerns - although I believe that the first part of the error message could be more clear about what has failed. One has to deduce it from the "following calls were made" part. Having the Cypress.sinon.match object stringified in a way it is stringified doesn't help much either.

[bahmutov]

🎉 This PR is included in version 2.9.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀