Add postgresql_grant_role resource #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Danny Hermes <[email protected]>
Co-authored-by: Danny Hermes <[email protected]>
Co-authored-by: Danny Hermes <[email protected]>
Co-authored-by: Danny Hermes <[email protected]>
|
@dvdliao Thanks for recreating it here, Hashicorp should have migrated the PRs & issues of the old repository but as it's still not the case we'll use this one. I'll take a look this week-end. Could you just rebase on master? I fixed the Travis build so it should pass now. |
|
@cyrilgdn done. thanks! |
cyrilgdn
requested changes
Dec 12, 2020
|
|
||
| ~> **Note:** This resource needs PostgreSQL version 9 or above. | ||
|
|
||
| ~> **Note:** `postgresql_grant_role` **cannot** be used in conjunction with `postgresql_role` or they will fight over what your role grants should be. |
There was a problem hiding this comment.
Nice 👍 I encountered this conflict during my test and I was about to say that we need that we need to add this warning but you already added it 😊
Closed
|
@cyrilgdn done and thanks! |
cyrilgdn
reviewed
Dec 14, 2020
|
@cyrilgdn done |
|
hey @cyrilgdn any idea when a release will be cut? i see the milestone as completed https://github.com/cyrilgdn/terraform-provider-postgresql/milestone/2?closed=1 |
wilsonjackson
referenced
this pull request
in Leafly-com/terraform-provider-postgresql
Jan 6, 2023
Update from upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying from hashicorp/terraform-provider-postgresql#189
Fix #6