Quote publication names as identifiers in SQL statements #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that publication names with special characters can be created
airhorns
force-pushed
the
quote-publication-name
branch
2 times, most recently
from
7aeca28 to
c3c4a26
Compare
airhorns
force-pushed
the
quote-publication-name
branch
from
c3c4a26 to
968e5bf
Compare
|
ping @cyrilgdn it would be really great to get this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating publications with things like dashes in the name didn't work before, erroring with
Error: Error creating Publication: pq: syntax error at or near "-". Publication names should be quoted to allow characters like this, just like table names (though they don't have a schema).