Skip to content

Conversation

@claudiu-cristea
Copy link

I'm getting this notice:

Notice: Undefined property: stdClass::$language in includes/common.inc on line 1560

@rmuit
Copy link
Contributor

rmuit commented Jan 22, 2021

I can't decide if we generally want this.

It does preserve current functionality, but it also feels like it could cover up deeper issues. What happens if some buggy module passes a language string in $options['language'], rather than an object? You'd want to see the notice rather than have "" being used. (Though stock Drupal unfortunately suppresses Notices...)

That's not your situation, where $options['language'] contains an incomplete object... I can't really think of when that would happen. Will keep a look out while running a multilanguage D6 site through simpletest.

@izmeez
Copy link

izmeez commented Jan 22, 2022

@rmuit Did you arrive at any further conclusions on this issue with the multilanguage D6 site?

@rmuit
Copy link
Contributor

rmuit commented Jun 12, 2022

I have now finished testing some multilanguage sites on PHP8.1. (With the simpletest patch applied, otherwise notices are ignored.) I have not encountered any notices in url(). So I'm strengthened in my hesitance to apply this.

@izmeez did you encounter that notice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants