Fix notices (non-fatal, so fixing optional) #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue of type null” when called repeatedly on the same result set. (PHP7.4; Warning in PHP8)
…t screen (PHP7.4)
…t_topics() (PHP7.4)
…s_path() (#3084953 backport; PHP7.4)
… going on rather than just adding an isset() somewhere. (Functionally equivalent, though.)
rmuit
commented
Jan 21, 2021
| * An array of mlid, title pairs for use as options for selecting a book page. | ||
| */ | ||
| function book_toc($bid, $exclude = array(), $depth_limit) { | ||
| function book_toc($bid, $exclude, $depth_limit) { |
Contributor
Author
There was a problem hiding this comment.
PHP8.0 emits a "Deprecated" notice. Look at us being future proof ;)
rmuit
commented
Jan 21, 2021
|
|
||
| $order = _forum_get_topic_order($sortby); | ||
| for ($i = 0; $i < count($forum_topic_list_header); $i++) { | ||
| for ($i = 1; $i < count($forum_topic_list_header); $i++) { |
Contributor
Author
There was a problem hiding this comment.
The reason for this change being good, can be seen in line 576 ^
|
The changes were applied as one patch to a site and caused a conflict with the captcha module causing it to fail every time. I have not had time to apply each segment individually to identify the culprit hunk. See https://www.drupal.org/project/d6lts/issues/3267856 |
Contributor
Author
|
See https://www.drupal.org/project/d6lts/issues/3267856#comment-14559831 for why I think (in my case) the captcha module apparently always fails since version 2.6. Plus a patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all notices which I encountered while running simpletest-D6 (https://github.com/rmuit/simpletest) on PHP7.4 / PHP8.0. Regular (non-Pressflow) Drupal will never see them because drupal_error_handler() ignores PHP Notice / Deprecated messages. Eek.
But I figured I'd scoop them up into 1 PR for those interested.
None of these fixes cover up bugs; every notice happens in cases where the 'input' value is legit.
Most of them are simple one-line fixes, except: