-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA Highlight
Unhighlight
Event Modifier를 추가해요.
#46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sources/KarrotListKit/Cell.swift
Outdated
registerEvent(HighlightEvent(handler: handler)) | ||
} | ||
|
||
/// Register a callback handler that will be called when the cell was unhighlight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p4) was + p.p 문법으로 봤을때는 다음과 같이 변경해야되지 않을까요?ㅎㅎ
/// Register a callback handler that will be called when the cell was unhighlight. | |
/// Register a callback handler that will be called when the cell was unhighlighted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅋㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅋㅋㅋ aa79209
�위 커밋에서 수정했어요 감사해요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 👍
배경
Highlight
,Unhighlight
Event Modifier를 추가해요.수정 내역
테스트 방법