Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA Highlight Unhighlight Event Modifier를 추가해요. #46

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

jaxtynSong
Copy link
Contributor

배경

  • 미구현된 Highlight, Unhighlight Event Modifier를 추가해요.

수정 내역

  • HighlightEvent 추가
  • UnhighlightEvent 추가
  • 이벤트 연동
  • 테스트 코드 작성

테스트 방법

  • 유닛 테스트 통과

@jaxtynSong jaxtynSong added the Feature New feature or request label Dec 11, 2024
@jaxtynSong jaxtynSong self-assigned this Dec 11, 2024
@jaxtynSong jaxtynSong added Improvement Update and removed Feature New feature or request labels Dec 11, 2024
Copy link
Member

@OhKanghoon OhKanghoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

registerEvent(HighlightEvent(handler: handler))
}

/// Register a callback handler that will be called when the cell was unhighlight.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4) was + p.p 문법으로 봤을때는 다음과 같이 변경해야되지 않을까요?ㅎㅎ

Suggested change
/// Register a callback handler that will be called when the cell was unhighlight.
/// Register a callback handler that will be called when the cell was unhighlighted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋ aa79209
�위 커밋에서 수정했어요 감사해요~

Copy link
Contributor

@ppth0608 ppth0608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@jaxtynSong jaxtynSong merged commit 9d7a508 into main Dec 11, 2024
1 check passed
@jaxtynSong jaxtynSong deleted the highlight-event-modifier branch December 11, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants