Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

노출된 View 사이즈 캐시 로직을 구현해요. #48

Merged
merged 2 commits into from
Jan 24, 2025
Merged

노출된 View 사이즈 캐시 로직을 구현해요. #48

merged 2 commits into from
Jan 24, 2025

Conversation

jaxtynSong
Copy link
Contributor

배경

  • Building high-performance lists and collection views sample project 내용을 참고하여 스크롤 성능을 개선해요.
  • 이미 노출된 View도 preferredLayoutAttributesFitting가 여러번 호출될 수 있어요.
  • 불필요한 호출로 성능이 저하될 수 있는 부분을 개선해요.

수정 내역

  • feature flag를 적용하여 기능 on/off 가능하도록 해요.
  • 이미 노출된 view 사이즈를 캐시하여 preferredLayoutAttributesFitting 비용을 낮춰요.

테스트 방법

  • �로컬에서 앱 연동 테스트 진행

@jaxtynSong jaxtynSong self-assigned this Jan 17, 2025
@jaxtynSong jaxtynSong force-pushed the using-cachedSize-for-performance branch from 2801123 to b597f56 Compare January 24, 2025 07:19
OhKanghoon
OhKanghoon approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@OhKanghoon OhKanghoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaxtynSong jaxtynSong merged commit 3ec6dab into main Jan 24, 2025
1 check passed
@jaxtynSong jaxtynSong deleted the using-cachedSize-for-performance branch January 24, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OhKanghoon OhKanghoon OhKanghoon approved these changes

@ppth0608 ppth0608 Awaiting requested review from ppth0608

Assignees

@jaxtynSong jaxtynSong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaxtynSong @OhKanghoon