This repository was archived by the owner on Sep 28, 2022. It is now read-only.
Expand serialization_specs recursively #44
Merged
+617
−404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also extract tests into different files
# Conflicts: # tests/tests.py
serialization_spec/serialization.py
Outdated
| self.serialization_spec = self.get_serialization_spec() | ||
| self.serialization_spec = get_serialization_spec(self) | ||
| if self.serialization_spec is None: | ||
| raise Exception('SerializationSpecMixin requires serialization_spec or get_serialization_spec') |
There was a problem hiding this comment.
Might be nice to raise a more descript exception here, eg django.core.exceptions.ImproperlyConfigured?
pmg103
force-pushed
the
various-fixes
branch
from
65b2d1c to
7d42791
Compare
RealOrangeOne
approved these changes
Sep 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #38
Also extract tests into different files