Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/airlift-mwaa-example/dags/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apache-airflow>=2.0.0,<2.8
apache-airflow>=3.3.0,<3.4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Airflow 3.3.x not yet supported by MWAA service

The MWAA service currently supports Apache Airflow up to version 3.2.1. Pinning apache-airflow>=3.3.0,<3.4 in the MWAA integration files means no MWAA environment can satisfy this requirement, so integration tests that provision or target a real MWAA environment will fail at environment-creation time. The same constraint applies to airflow_project/requirements.txt. Consider aligning with the highest MWAA-available version (>=3.2.0,<3.3 or similar) until MWAA adds 3.3.x support.

flask-session<0.6.0
connexion<3.0.0
pendulum>=2.0.0,<3.0.0
Comment on lines +1 to 4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 pendulum<3.0.0 conflicts with Airflow 3.x on Python 3.12+

Apache Airflow 3.x requires pendulum>=3.0.0 when running on Python 3.12+, but this file still pins pendulum>=2.0.0,<3.0.0. On any Python 3.12 environment, pip/uv will refuse to resolve this combination, making the environment uninstallable. Both MWAA files (dags/requirements.txt and airflow_project/requirements.txt) need pendulum>=3.0.0,<4.0.0 (or simply pendulum>=2.0.0,<4.0.0) to be compatible with the new Airflow floor.

Expand Down
2 changes: 1 addition & 1 deletion examples/docs_projects/project_dspy/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies = [
"dagster",
"dspy>=2.6.27",
"ipykernel>=6.30.1",
"litellm==1.83.7",
"litellm==1.84.0",
"openai>=1.107.2",
"pandas>=2.3.2",
"pydantic>=2.11.9",
Expand Down
2 changes: 1 addition & 1 deletion examples/docs_snippets/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ full = [
"syrupy",
"xgboost",
"apache-airflow<3.0.0; python_version < '3.12'",
"apache-airflow>=3.2; python_version >= '3.12'",
"apache-airflow>=3.3.0; python_version >= '3.12'",
"pytest-httpserver",
]

Expand Down
2 changes: 1 addition & 1 deletion examples/starlift-demo/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies = [
"dagster-dbt",
"dbt-duckdb",
"pandas",
"apache-airflow<3.0.0",
"apache-airflow<4.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Widening upper bound to <4.0.0 admits Airflow 3.x without validation

The previous <3.0.0 cap kept Airflow 2.x only. Allowing Airflow 3.x here is a larger behaviour change than a routine version bump: Airflow 3.0 introduced breaking changes (new task execution API, DAG serialisation changes, removed legacy features). If dagster-airlift hasn't been validated against Airflow 3.x in this demo project, CI could pass locally while the demo itself is broken for users installing Airflow 3.x.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

]

[project.optional-dependencies]
Expand Down
2 changes: 1 addition & 1 deletion examples/with_wandb/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies = [
"skl2onnx",
# 1.21.0 is the first release that ships cp314 manylinux wheels; the 1.17.0
# sdist won't compile against gcc 14 / abseil headers on Python 3.14.
"onnx>=1.21.0",
"onnx>=1.22.0",
"joblib",
"torch",
"torchvision",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apache-airflow>=2.0.0,<2.8
apache-airflow>=3.3.0,<3.4
flask-session<0.6.0
connexion<3.0.0
pendulum>=2.0.0,<3.0.0
Loading