Skip to content

Commit

Permalink
feat!: Sundown .NET6.0 and .NET7.0 (#484)
Browse files Browse the repository at this point in the history
* feat!: Sundown `.NET6.0` and `.NET7.0`

* chore: Removed `NetEvolve.HealthChecks.SqlEdge`, this is no longer supported

* chore(deps): Upgraded TestContainers to `4.0.0`

* chore(deps): Upgraded nuget packages

+ NetEvolve.Extensions.XUnit
+ Oracle.ManagedDataAccess.Core
+ Verify.Xunit

* fix: Minor warnings

* style: reformatted code
  • Loading branch information
samtrion authored Nov 3, 2024
1 parent 4c71bef commit 4a970af
Show file tree
Hide file tree
Showing 33 changed files with 58 additions and 1,003 deletions.
4 changes: 2 additions & 2 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
<Import Project="$(DirEngineeringSettings)tests.build.props" Condition=" '$(IsTestableProject)' == 'true' " />

<PropertyGroup Label="General settings for all projects">
<_ProjectTargetFrameworks>net6.0;net7.0;net8.0</_ProjectTargetFrameworks>
<_TestTargetFrameworks>net6.0;net7.0;net8.0</_TestTargetFrameworks>
<_ProjectTargetFrameworks>net8.0;net9.0</_ProjectTargetFrameworks>
<_TestTargetFrameworks>net8.0;net9.0</_TestTargetFrameworks>
<_TestTargetFrameworks Condition=" '$(BuildingInsideVisualStudio)' == 'true' ">net8.0</_TestTargetFrameworks>
</PropertyGroup>

Expand Down
38 changes: 17 additions & 21 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -30,36 +30,32 @@
<PackageVersion Include="MySqlConnector" Version="2.3.7" />
<PackageVersion Include="NetEvolve.Arguments" Version="1.2.100" />
<PackageVersion Include="NetEvolve.Extensions.Tasks" Version="1.2.113" />
<PackageVersion Include="NetEvolve.Extensions.XUnit" Version="2.3.0" />
<PackageVersion Include="NetEvolve.Extensions.XUnit" Version="2.3.1" />
<PackageVersion Include="Npgsql" Version="8.0.5" />
<PackageVersion Include="NSubstitute" Version="5.3.0" />
<PackageVersion Include="NSubstitute.Analyzers.CSharp" Version="1.0.17" />
<PackageVersion Include="Oracle.ManagedDataAccess.Core" Version="23.5.1" />
<PackageVersion Include="Oracle.ManagedDataAccess.Core" Version="23.6.0" />
<PackageVersion Include="Polyfill" Version="7.2.0" />
<PackageVersion Include="StackExchange.Redis" Version="2.8.16" />
<PackageVersion Include="System.Data.SqlClient" Version="4.8.6" />
<PackageVersion Include="Testcontainers.Azurite" Version="3.10.0" />
<PackageVersion Include="Testcontainers.ClickHouse" Version="3.10.0" />
<PackageVersion Include="Testcontainers.Kafka" Version="3.10.0" />
<PackageVersion Include="Testcontainers.MsSql" Version="3.10.0" />
<PackageVersion Include="Testcontainers.MySql" Version="3.10.0" />
<PackageVersion Include="Testcontainers.Oracle" Version="3.10.0" />
<PackageVersion Include="Testcontainers.PostgreSql" Version="3.10.0" />
<PackageVersion Include="Testcontainers.Redis" Version="3.10.0" />
<PackageVersion Include="Testcontainers.Redpanda" Version="3.10.0" />
<PackageVersion Include="Testcontainers.SqlEdge" Version="3.10.0" />
<PackageVersion Include="Testcontainers.Azurite" Version="4.0.0" />
<PackageVersion Include="Testcontainers.ClickHouse" Version="4.0.0" />
<PackageVersion Include="Testcontainers.Kafka" Version="4.0.0" />
<PackageVersion Include="Testcontainers.MsSql" Version="4.0.0" />
<PackageVersion Include="Testcontainers.MySql" Version="4.0.0" />
<PackageVersion Include="Testcontainers.Oracle" Version="4.0.0" />
<PackageVersion Include="Testcontainers.PostgreSql" Version="4.0.0" />
<PackageVersion Include="Testcontainers.Redis" Version="4.0.0" />
<PackageVersion Include="Testcontainers.Redpanda" Version="4.0.0" />
<PackageVersion Include="TngTech.ArchUnitNET.xUnit" Version="0.11.1" />
<PackageVersion Include="Verify.Xunit" Version="28.1.0" />
<PackageVersion Include="Verify.Xunit" Version="28.1.3" />
<PackageVersion Include="xunit" Version="2.9.2" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net8.0'">
<PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="8.0.8" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net7.0'">
<PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="7.0.19" />
<ItemGroup Condition=" '$(TargetFramework)' == 'net9.0'">
<PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="9.0.0-rc.2.24474.3" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0'">
<PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="6.0.31" />
<ItemGroup Condition=" '$(TargetFramework)' == 'net8.0'">
<PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="8.0.10" />
</ItemGroup>
</Project>
</Project>
57 changes: 1 addition & 56 deletions HealthChecks.sln
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
# 17
VisualStudioVersion = 17.0.31903.59
MinimumVisualStudioVersion = 10.0.40219.1
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{6CB71215-8619-4502-A91B-9711981EC78A}"
Expand Down Expand Up @@ -155,18 +155,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{581B0835
EndProject
Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "NetEvolve.HealthChecks.Shared.Tests", "src\HealthChecks.Shared\tests\NetEvolve.HealthChecks.Shared.Tests\NetEvolve.HealthChecks.Shared.Tests.shproj", "{A460F166-5BF9-4817-9A7B-EEFAA6EAAA08}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "HealthChecks.SqlEdge", "HealthChecks.SqlEdge", "{030DC947-17AC-4B93-951A-FBDEFE26137C}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{ABBFFAD0-ECB9-491C-A05F-B53DD4566FEE}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "NetEvolve.HealthChecks.SqlEdge", "src\HealthChecks.SqlEdge\src\NetEvolve.HealthChecks.SqlEdge\NetEvolve.HealthChecks.SqlEdge.csproj", "{C3B974B6-B39A-4059-AC26-F7C8B4864394}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{92E6E195-A1CE-4324-8301-E51AC97ABF7C}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "NetEvolve.HealthChecks.SqlEdge.Tests.Unit", "src\HealthChecks.SqlEdge\tests\NetEvolve.HealthChecks.SqlEdge.Tests.Unit\NetEvolve.HealthChecks.SqlEdge.Tests.Unit.csproj", "{C11653AC-3AE6-42A3-935E-76CB72336CEF}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "NetEvolve.HealthChecks.SqlEdge.Tests.Integration", "src\HealthChecks.SqlEdge\tests\NetEvolve.HealthChecks.SqlEdge.Tests.Integration\NetEvolve.HealthChecks.SqlEdge.Tests.Integration.csproj", "{A9C0419E-0FF1-4F06-A677-F974C2525EC8}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "HealthChecks.ClickHouse", "HealthChecks.ClickHouse", "{3C74B948-3DA4-4AD9-96B6-0B92202513ED}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{B8FABBFB-BA61-43E7-9925-214C4DC4A12E}"
Expand Down Expand Up @@ -627,42 +615,6 @@ Global
{81F6A354-2A58-4666-A5AA-B587F6249403}.Release|x64.Build.0 = Release|Any CPU
{81F6A354-2A58-4666-A5AA-B587F6249403}.Release|x86.ActiveCfg = Release|Any CPU
{81F6A354-2A58-4666-A5AA-B587F6249403}.Release|x86.Build.0 = Release|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Debug|Any CPU.Build.0 = Debug|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Debug|x64.ActiveCfg = Debug|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Debug|x64.Build.0 = Debug|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Debug|x86.ActiveCfg = Debug|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Debug|x86.Build.0 = Debug|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Release|Any CPU.ActiveCfg = Release|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Release|Any CPU.Build.0 = Release|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Release|x64.ActiveCfg = Release|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Release|x64.Build.0 = Release|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Release|x86.ActiveCfg = Release|Any CPU
{C3B974B6-B39A-4059-AC26-F7C8B4864394}.Release|x86.Build.0 = Release|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Debug|Any CPU.Build.0 = Debug|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Debug|x64.ActiveCfg = Debug|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Debug|x64.Build.0 = Debug|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Debug|x86.ActiveCfg = Debug|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Debug|x86.Build.0 = Debug|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Release|Any CPU.ActiveCfg = Release|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Release|Any CPU.Build.0 = Release|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Release|x64.ActiveCfg = Release|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Release|x64.Build.0 = Release|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Release|x86.ActiveCfg = Release|Any CPU
{C11653AC-3AE6-42A3-935E-76CB72336CEF}.Release|x86.Build.0 = Release|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Debug|Any CPU.Build.0 = Debug|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Debug|x64.ActiveCfg = Debug|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Debug|x64.Build.0 = Debug|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Debug|x86.ActiveCfg = Debug|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Debug|x86.Build.0 = Debug|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Release|Any CPU.ActiveCfg = Release|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Release|Any CPU.Build.0 = Release|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Release|x64.ActiveCfg = Release|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Release|x64.Build.0 = Release|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Release|x86.ActiveCfg = Release|Any CPU
{A9C0419E-0FF1-4F06-A677-F974C2525EC8}.Release|x86.Build.0 = Release|Any CPU
{F0D843B5-3F10-42F0-BB04-B983C96B8A5E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{F0D843B5-3F10-42F0-BB04-B983C96B8A5E}.Debug|Any CPU.Build.0 = Debug|Any CPU
{F0D843B5-3F10-42F0-BB04-B983C96B8A5E}.Debug|x64.ActiveCfg = Debug|Any CPU
Expand Down Expand Up @@ -974,12 +926,6 @@ Global
{57C27713-6D48-48CF-9179-92D3F9394A1E} = {EF615D18-42E2-48A4-8EBA-E652DC574C56}
{581B0835-C239-41E7-9A68-CB49C0921D8A} = {57C27713-6D48-48CF-9179-92D3F9394A1E}
{A460F166-5BF9-4817-9A7B-EEFAA6EAAA08} = {581B0835-C239-41E7-9A68-CB49C0921D8A}
{030DC947-17AC-4B93-951A-FBDEFE26137C} = {EF615D18-42E2-48A4-8EBA-E652DC574C56}
{ABBFFAD0-ECB9-491C-A05F-B53DD4566FEE} = {030DC947-17AC-4B93-951A-FBDEFE26137C}
{C3B974B6-B39A-4059-AC26-F7C8B4864394} = {ABBFFAD0-ECB9-491C-A05F-B53DD4566FEE}
{92E6E195-A1CE-4324-8301-E51AC97ABF7C} = {030DC947-17AC-4B93-951A-FBDEFE26137C}
{C11653AC-3AE6-42A3-935E-76CB72336CEF} = {92E6E195-A1CE-4324-8301-E51AC97ABF7C}
{A9C0419E-0FF1-4F06-A677-F974C2525EC8} = {92E6E195-A1CE-4324-8301-E51AC97ABF7C}
{3C74B948-3DA4-4AD9-96B6-0B92202513ED} = {EF615D18-42E2-48A4-8EBA-E652DC574C56}
{B8FABBFB-BA61-43E7-9925-214C4DC4A12E} = {3C74B948-3DA4-4AD9-96B6-0B92202513ED}
{F0D843B5-3F10-42F0-BB04-B983C96B8A5E} = {B8FABBFB-BA61-43E7-9925-214C4DC4A12E}
Expand Down Expand Up @@ -1035,7 +981,6 @@ Global
src\HealthChecks.Shared\tests\NetEvolve.HealthChecks.Shared.Tests\NetEvolve.HealthChecks.Shared.Tests.projitems*{83fc6528-bd04-434b-8fcd-34c5191e54fb}*SharedItemsImports = 5
src\HealthChecks.Shared\tests\NetEvolve.HealthChecks.Shared.Tests\NetEvolve.HealthChecks.Shared.Tests.projitems*{8b6ffc25-4c06-4258-93a6-d083bd9128dc}*SharedItemsImports = 5
src\HealthChecks.Shared\tests\NetEvolve.HealthChecks.Shared.Tests\NetEvolve.HealthChecks.Shared.Tests.projitems*{8dbfda03-069e-4efa-83e7-275a6859227b}*SharedItemsImports = 5
src\HealthChecks.Shared\tests\NetEvolve.HealthChecks.Shared.Tests\NetEvolve.HealthChecks.Shared.Tests.projitems*{a9c0419e-0ff1-4f06-a677-f974c2525ec8}*SharedItemsImports = 5
src\HealthChecks.Shared\tests\NetEvolve.HealthChecks.Shared.Tests\NetEvolve.HealthChecks.Shared.Tests.projitems*{ad0ee9cb-86b7-4f46-90fc-15a1a01b8e56}*SharedItemsImports = 5
src\HealthChecks.Shared\tests\NetEvolve.HealthChecks.Shared.Tests\NetEvolve.HealthChecks.Shared.Tests.projitems*{c51b46f9-6b07-4954-94e5-02eb49e205d2}*SharedItemsImports = 5
src\HealthChecks.Shared\tests\NetEvolve.HealthChecks.Shared.Tests\NetEvolve.HealthChecks.Shared.Tests.projitems*{ccd26d0d-5869-4727-9b62-31442d060adc}*SharedItemsImports = 5
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ CancellationToken cancellationToken
/// <returns>
/// A <see cref="HealthCheckResult"/> with <see cref="HealthStatus.Healthy"/> or <see cref="HealthStatus.Degraded"/>.
/// </returns>
protected HealthCheckResult HealthCheckState(bool condition, string name) =>
protected static HealthCheckResult HealthCheckState(bool condition, string name) =>
condition
? HealthCheckResult.Healthy($"{name}: Healthy")
: HealthCheckResult.Degraded($"{name}: Degraded");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
using NetEvolve.HealthChecks.Oracle;
using NetEvolve.HealthChecks.Redis;
using NetEvolve.HealthChecks.Redpanda;
using NetEvolve.HealthChecks.SqlEdge;
using NetEvolve.HealthChecks.SQLite;
using NetEvolve.HealthChecks.SqlServer;
using NetEvolve.HealthChecks.SqlServer.Legacy;
Expand All @@ -25,7 +24,7 @@ internal static class HealthCheckArchitecture
{
// TIP: load your architecture once at the start to maximize performance of your tests
private static readonly Lazy<Architecture> _instance = new Lazy<Architecture>(
() => LoadArchitecture(),
LoadArchitecture,
LazyThreadSafetyMode.PublicationOnly
);

Expand All @@ -47,7 +46,6 @@ private static Architecture LoadArchitecture()
typeof(OracleCheck).Assembly,
typeof(RedisDatabaseHealthCheck).Assembly,
typeof(RedpandaCheck).Assembly,
typeof(SqlEdgeCheck).Assembly,
typeof(SQLiteCheck).Assembly,
typeof(SqlServerCheck).Assembly,
typeof(SqlServerLegacyCheck).Assembly,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
namespace NetEvolve.HealthChecks.Abstractions.Tests.Architecture;

using ArchUnitNET.Domain;
using ArchUnitNET.Fluent.Syntax.Elements.Members;
using ArchUnitNET.xUnit;
using Microsoft.Extensions.Diagnostics.HealthChecks;
using Xunit;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
<ProjectReference Include="..\..\..\HealthChecks.Oracle\src\NetEvolve.HealthChecks.Oracle\NetEvolve.HealthChecks.Oracle.csproj" />
<ProjectReference Include="..\..\..\HealthChecks.Redis\src\NetEvolve.HealthChecks.Redis\NetEvolve.HealthChecks.Redis.csproj" />
<ProjectReference Include="..\..\..\HealthChecks.Redpanda\src\NetEvolve.HealthChecks.Redpanda\NetEvolve.HealthChecks.Redpanda.csproj" />
<ProjectReference Include="..\..\..\HealthChecks.SqlEdge\src\NetEvolve.HealthChecks.SqlEdge\NetEvolve.HealthChecks.SqlEdge.csproj" />
<ProjectReference Include="..\..\..\HealthChecks.SQLite\src\NetEvolve.HealthChecks.SQLite\NetEvolve.HealthChecks.SQLite.csproj" />
<ProjectReference Include="..\..\..\HealthChecks.SqlServer.Legacy\src\NetEvolve.HealthChecks.SqlServer.Legacy\NetEvolve.HealthChecks.SqlServer.Legacy.csproj" />
<ProjectReference Include="..\..\..\HealthChecks.SqlServer\src\NetEvolve.HealthChecks.SqlServer\NetEvolve.HealthChecks.SqlServer.csproj" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ IServiceProvider serviceProvider
options.ConfigureClientOptions(clientOptions);
}

#pragma warning disable IDE0010 // Add missing cases
switch (options.Mode)
{
case BlobClientCreationMode.DefaultAzureCredentials:
Expand Down Expand Up @@ -82,5 +83,6 @@ IServiceProvider serviceProvider
default:
throw new UnreachableException($"Invalid client creation mode `{options.Mode}`.");
}
#pragma warning restore IDE0010 // Add missing cases
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,18 @@ public void CreateBlobServiceClient_InvalidMode_ThrowUnreachableException()
() => ClientCreation.CreateBlobServiceClient(options, serviceProvider)
);
}

[Fact]
public void CreateBlobServiceClient_ModeServiceProvider_ThrowUnreachableException()
{
var options = new BlobContainerAvailableOptions
{
Mode = BlobClientCreationMode.ServiceProvider,
};
var serviceProvider = new ServiceCollection().BuildServiceProvider();

_ = Assert.Throws<UnreachableException>(
() => ClientCreation.CreateBlobServiceClient(options, serviceProvider)
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ IServiceProvider serviceProvider
options.ConfigureClientOptions(clientOptions);
}

#pragma warning disable IDE0010 // Add missing cases
switch (options.Mode)
{
case QueueClientCreationMode.DefaultAzureCredentials:
Expand Down Expand Up @@ -82,5 +83,6 @@ IServiceProvider serviceProvider
default:
throw new UnreachableException($"Invalid client creation mode `{options.Mode}`.");
}
#pragma warning restore IDE0010 // Add missing cases
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,18 @@ public void CreateQueueServiceClient_InvalidMode_ThrowUnreachableException()
() => ClientCreation.CreateQueueServiceClient(options, serviceProvider)
);
}

[Fact]
public void CreateQueueServiceClient_ModeServiceProvider_ThrowUnreachableException()
{
var options = new QueueClientAvailableOptions
{
Mode = QueueClientCreationMode.ServiceProvider,
};
var serviceProvider = new ServiceCollection().BuildServiceProvider();

_ = Assert.Throws<UnreachableException>(
() => ClientCreation.CreateQueueServiceClient(options, serviceProvider)
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ IServiceProvider serviceProvider
options.ConfigureClientOptions(clientOptions);
}

#pragma warning disable IDE0010 // Add missing cases
switch (options.Mode)
{
case TableClientCreationMode.DefaultAzureCredentials:
Expand Down Expand Up @@ -81,5 +82,6 @@ IServiceProvider serviceProvider
default:
throw new UnreachableException($"Invalid client creation mode `{options.Mode}`.");
}
#pragma warning restore IDE0010 // Add missing cases
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
[ExcludeFromCodeCoverage]
public sealed class SQLiteDatabase : IAsyncLifetime
{
#pragma warning disable S2325 // Methods and properties that don't access instance data should be static
public string ConnectionString => "Data Source=:memory:";
#pragma warning restore S2325 // Methods and properties that don't access instance data should be static

public Task DisposeAsync() => Task.CompletedTask;

Expand Down
Loading

0 comments on commit 4a970af

Please sign in to comment.