feat: add user flags, profile experiences and autocomplete for profile interim #2944

ilasw · 2025-07-23T14:36:15Z

Added user profile user experiences, skills, flags, job preferences, and a new autocomplete endopoint.

Jira ticket

pulumi · 2025-07-23T14:37:42Z

🍹 The Update (preview) for dailydotdev/api/prod (at 7cfac9f) was successful.

Resource Changes

    Name                                            Type                           Operation
~   vpc-native-generic-referral-reminder-cron       kubernetes:batch/v1:CronJob    update
~   vpc-native-temporal-deployment                  kubernetes:apps/v1:Deployment  update
~   vpc-native-bg-deployment                        kubernetes:apps/v1:Deployment  update
~   vpc-native-clean-zombie-images-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron  kubernetes:batch/v1:CronJob    update
-   vpc-native-api-migration-c7950645               kubernetes:batch/v1:Job        delete
~   vpc-native-sync-subscription-with-cio-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-update-highlighted-views-cron        kubernetes:batch/v1:CronJob    update
~   vpc-native-update-views-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-tag-view-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                        kubernetes:apps/v1:Deployment  update
~   vpc-native-deployment                           kubernetes:apps/v1:Deployment  update
~   vpc-native-clean-zombie-users-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-recommendations-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-check-analytics-report-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron     kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron   kubernetes:batch/v1:CronJob    update
~   vpc-native-validate-active-users-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-deployment       kubernetes:apps/v1:Deployment  update
~   vpc-native-update-tags-str-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-hourly-notification-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-calculate-top-readers-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-daily-digest-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-generate-search-invites-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-private-deployment                   kubernetes:apps/v1:Deployment  update
+   vpc-native-api-migration-be98f313               kubernetes:batch/v1:Job        create
~   vpc-native-update-trending-cron                 kubernetes:batch/v1:CronJob    update

…I-953-profile-interim

… entities

…ileAutocomplete

capJavert · 2025-07-29T14:28:17Z

src/entity/Company.ts

+  @Column({
+    type: 'enum',
+    enum: CompanyType,
+    default: CompanyType.Business,
+  })


Type should be string on psql side, we only use enum to validate in code and gql. This allows us to adjust the type more freely without changing column type.

See other examples eg. user_transacton.status

capJavert · 2025-07-29T14:29:08Z

src/entity/user/User.ts

+  jobPreferences: Promise<UserJobPreferences>;
+
+  @OneToMany(() => UserExperience, (experience) => experience.user)
+  experiences: Promise<UserExperience[]>;


onDelete cascade?

capJavert

Some initial comments, quite a lot of entities added, see my comments and apply on sub entities/migrations as well, I did not want to repeat comments all over because it would just spam 😆

src/entity/user/UserJobPreferences.ts

capJavert · 2025-07-29T14:30:52Z

src/entity/user/UserJobPreferences.ts

+  // !! Never send this field to FE, is only stored for better recommendation !!
+  // Currency must be "ISO-4217" compliant
+  // Amount is yearly based
+  @Column({ type: 'jsonb', nullable: true })


we can make it {} as other jsonb fields I think

capJavert · 2025-07-29T14:31:32Z

src/entity/user/UserJobPreferences.ts

+  @Column({ default: false })
+  openToRelocation: boolean;
+
+  // !! Never send this field to FE, is only stored for better recommendation !!


this is controlled on gql type, so make sure its not included there so clients can't request it

capJavert · 2025-07-29T14:32:07Z

src/entity/user/UserSkill.ts

+  @BeforeInsert()
+  @BeforeUpdate()
+  generateSlug() {
+    this.slug = slugify(this.name);


see my comment about generated column, much better then before hooks of typeorm with only work per app instance

capJavert · 2025-07-29T14:32:27Z

src/entity/user/experiences/UserExperience.ts

+  @Column({
+    type: 'enum',
+    enum: UserExperienceType,
+    nullable: false,
+  })
+  type: UserExperienceType;
+
+  @Column({
+    type: 'enum',
+    enum: ExperienceStatus,
+    default: ExperienceStatus.Draft,
+  })
+  status: ExperienceStatus;


Same comment as above, type should be string

capJavert · 2025-07-29T14:33:42Z

src/entity/user/experiences/UserExperience.ts

+  @Column()
+  userId: string;
+
+  @ManyToOne(() => User, (user) => user.experiences)


for relentionships use import type { User } and string for entity:

Suggested change

@ManyToOne(() => User, (user) => user.experiences)

@ManyToOne('User', (user) => user.experiences)

it helps with dependency cycles, please update other places for new entities

capJavert · 2025-07-29T14:36:25Z

src/entity/user/experiences/UserProjectExperience.ts

+  @Column({ type: 'jsonb', nullable: true })
+  associatedWith: {
+    type: ExperienceAssociationType;
+    id: string;
+  };


FK can't be added on jsonb columns I think. Ideally we implement it through referenceId and specific columns workId, and educationId. Is it used anywhere in code, maybe we don't need to define it at all and see later?

This is a recurring association field for projects/publications/[...].
IMO we should define some kind of relationship, now or during MI-958, because that task will require it.

Maybe we can leave as is and check for it during deletion of experiences using CDC, wdyt?

If its FK you need then you will have to move it to columns as I said. CDC is not ideal better to do it on DB level with cascade.

capJavert · 2025-07-29T14:37:04Z

src/schema/profileAutocomplete.ts

+        throw new ValidationError(`Invalid autocomplete type: ${type}`);
+      }
+
+      if (!query || query.length < 2 || query.length > 100) {


can you do validations over zod?

…rray columns

…tocomplete params

…tedWith fields

Copilot

Pull Request Overview

This PR implements a comprehensive user profile system with experience tracking and autocomplete functionality. It adds user experience entities for work, education, certifications, awards, publications, courses, and projects, along with job preferences and skills management. A new GraphQL autocomplete endpoint enables searching across various profile fields like job titles, companies, skills, and educational institutions.

Introduces multiple user experience entity types with a hierarchical structure using TypeORM table inheritance
Adds user job preferences with compensation tracking and work location preferences
Implements a flexible autocomplete system supporting 10 different search types with proper validation

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/schema/profileAutocomplete.ts	Core autocomplete implementation with GraphQL schema, resolvers, and query mapping
src/graphql.ts	Registers the new autocomplete schema and resolvers with the GraphQL server
src/entity/user/experiences/*.ts	Defines experience entity hierarchy with base UserExperience and specialized child entities
src/entity/user/UserSkill.ts	User skills entity with auto-generated slug and many-to-many relationship to experiences
src/entity/user/UserJobPreferences.ts	Job preferences including compensation, location type, and role preferences
src/entity/user/User.ts	Extends User entity with new relationships and location flags
src/entity/Company.ts	Adds company type enum to distinguish between businesses and schools
tests/profileAutocomplete.ts	Comprehensive test suite covering validation, skills, job titles, and company autocomplete

Comments suppressed due to low confidence (1)

src/entity/user/UserJobPreferences.ts:39

The TODO comment references a different ticket (MI-958) than the one mentioned in the PR description (MI-953). This could cause confusion about which ticket handles the sensitive data protection.

  // todo: never send this field to FE while implementing MI-953

Copilot · 2025-07-30T14:46:40Z

src/schema/profileAutocomplete.ts

+        queryRunner.manager
+          .getRepository(entity)
+          .createQueryBuilder('entity')
+          .select(select ?? ['id', propertyName])


The select clause uses propertyName directly which may not work correctly with TypeORM's select method. TypeORM expects column names prefixed with the alias. This should be entity.${propertyName} to match the query builder pattern.

Suggested change

.select(select ?? ['id', propertyName])

.select(select ?? [`entity.id`, `entity.${propertyName}`])

Copilot · 2025-07-30T14:46:40Z

src/schema/profileAutocomplete.ts

+  [AutocompleteType.CertificationName]: UserCertificationExperience;
+  [AutocompleteType.CertificationIssuer]: Company;
+  [AutocompleteType.AwardName]: UserAwardExperience;
+  [AutocompleteType.AwardIssuer]: UserAwardExperience;


The mapping for AwardIssuer points to UserAwardExperience but queries the 'issuer' field which is a string property, not a company entity. This is inconsistent with other issuer types like CertificationIssuer which correctly map to Company entity.

Suggested change

[AutocompleteType.AwardIssuer]: UserAwardExperience;

[AutocompleteType.AwardIssuer]: Company;

Copilot · 2025-07-30T14:46:40Z

src/entity/user/experiences/UserExperience.ts

+    default: ExperienceStatus.Draft,
+  })
+  status: ExperienceStatus;
+


The flags field lacks documentation explaining its purpose, expected structure, or usage patterns. Given its generic type, documentation would help developers understand what kind of flags can be stored.

Suggested change

/**

* A JSON object to store additional metadata or flags related to the user experience.

*

* This field is flexible and can store various key-value pairs. Examples of possible keys:

* - "isFeatured": A boolean indicating if the experience is featured.

* - "priority": A number representing the priority level of the experience.

* - "tags": An array of strings for categorization or tagging.

*

* Developers should ensure that the keys and values stored in this field are consistent

* with the application's requirements and properly validated before use.

*/

capJavert

Should be good to go once comments are addressed 👌

src/entity/user/experiences/UserAwardExperience.ts

src/graphql.ts

src/schema/profileAutocomplete.ts

capJavert · 2025-07-30T15:14:47Z

src/schema/profileAutocomplete.ts

+        queryRunner.manager
+          .getRepository(entity)
+          .createQueryBuilder('entity')
+          .select(select ?? ['id', propertyName])


src/schema/profileAutocomplete.ts

capJavert · 2025-07-30T15:16:44Z

src/schema/profileAutocomplete.ts

+        query,
+        limit,
+        hits: hits.map((hit) => ({
+          __typename: typeNameByEntity[entity.name],


why do we need __typename?

I've added one endpoint for Company, UserSkill and UserExperience.
GQL requires to add the typename in order to understand what I'm returning, I don't know how to avoid it (also linked to #2944 (comment) )

Hmm this is weird, lets take a look tomorrow, I don't think we do this anywhere (at least not manually like this), I see __typename in some old parts of code but just on types not actual returns.

src/schema/profileAutocomplete.ts

src/entity/Company.ts

…lt value for description column

…953-profile-interim # Conflicts: # __tests__/profileAutocomplete.ts # src/migration/1753885628500-UserExperiences.ts

…th loggedUser

…ndition

…I-953-profile-interim

ilasw added 3 commits July 23, 2025 16:35

feat: add UserJobPreferences entity and relation in User

894aa23

feat: add Skill entity and slugify utility function

334bb43

Merge branch 'main' of https://github.com/dailydotdev/daily-api into M…

6178c9a

…I-953-profile-interim

ilasw added 13 commits July 23, 2025 17:14

Merge branch 'main' into MI-953-profile-interim

62a88cc

feat: add UserExperience entity and job preferences relation updates

daab508

feat: added CompanyType enum and type column in Company entity

b248902

Merge branch 'main' of https://github.com/dailydotdev/daily-api into M…

bfb3a08

…I-953-profile-interim

feat: added user experience entities

2c06306

fix: add missing type for columns

bfe37a1

feat: add migration for user experiences, skills, and job preferences…

4281c80

… entities

feat: initial autocomplete, wip correct typing

0bcec3e

fix: improve type safety in autocomplete and handle invalid type cases

6d467f6

feat: added GQL schema, optimized using read replica

f0d65ad

fix: linter, missing ;

aac2519

feat: added profileAutocomplete query with tests

153f543

feat: added image field

b88f0ba

ilasw changed the title ~~feat: profile interim~~ feat: add user flags, profile experiences and autocomplete for profile iterim Jul 29, 2025

ilasw requested a review from Copilot July 29, 2025 10:03

This comment was marked as outdated.

Sign in to view

ilasw changed the title ~~feat: add user flags, profile experiences and autocomplete for profile iterim~~ feat: add user flags, profile experiences and autocomplete for profile interim Jul 29, 2025

fix: removed debug logs and improved query parameter handling in prof…

69dd1d0

…ileAutocomplete

ilasw requested a review from Copilot July 29, 2025 10:44

This comment was marked as outdated.

Sign in to view

fix: updated column types to jsonb and set default limit in autocomplete

6a07d27

ilasw requested a review from Copilot July 29, 2025 11:11

This comment was marked as outdated.

Sign in to view

fix: standardized jsonb column defaults and corrected autocomplete slugs

5f86ca4

ilasw requested a review from Copilot July 29, 2025 13:44

This comment was marked as outdated.

Sign in to view

ilasw requested a review from AmarTrebinjac July 29, 2025 13:59

This comment was marked as outdated.

Sign in to view

capJavert reviewed Jul 29, 2025

View reviewed changes

ilasw added 4 commits July 30, 2025 10:51

fix: replaced manual slug generation with stored generated column

bd71143

refactor: removed unused slugify function in utils

0b8b92b

fix: updated company type column to string and removed enum constraint

7403d86

fix: updated column types, replaced enums with strings, and updated a…

971ca5b

…rray columns

ilasw requested review from capJavert and Copilot July 30, 2025 10:15

This comment was marked as outdated.

Sign in to view

ilasw added 2 commits July 30, 2025 15:25

fix: replaced migration

3901ab6

fix: updated column types to text, and added schema validation for au…

10c4f91

…tocomplete params

dailydotdev deleted a comment from Copilot AI Jul 30, 2025

ilasw added 3 commits July 30, 2025 15:32

refactor: better name for validation var

068a5f2

refactor: updated migration, added cascade delete and updated associa…

6c748e3

…tedWith fields

refactor: updated migration, added cascade delete and updated associa…

bbc1743

…tedWith fields

ilasw requested a review from Copilot July 30, 2025 14:45

Copilot AI reviewed Jul 30, 2025

View reviewed changes

dailydotdev deleted a comment from Copilot AI Jul 30, 2025

capJavert reviewed Jul 30, 2025

View reviewed changes

ilasw added 6 commits July 30, 2025 17:20

fix: added issuer field in autocomplete, updated migration with defau…

02a62fb

…lt value for description column

Merge remote-tracking branch 'origin/MI-953-profile-interim' into MI-…

8943a88

…953-profile-interim # Conflicts: # __tests__/profileAutocomplete.ts # src/migration/1753885628500-UserExperiences.ts

refactor: renamed profileAutocomplete to experienceAutocomplete

34a1627

fix: added auth check for experienceAutocomplete and updated tests wi…

d4103d9

…th loggedUser

fix: updated select statement to include entity prefix

0b824eb

fix: removed console log, updated default select and refined query co…

c554335

…ndition

ilasw requested a review from capJavert July 30, 2025 15:54

Merge branch 'main' of https://github.com/dailydotdev/daily-api into M…

7cfac9f

…I-953-profile-interim

	@ManyToOne(() => User, (user) => user.experiences)
	@ManyToOne('User', (user) => user.experiences)

	.select(select ?? ['id', propertyName])
	.select(select ?? [`entity.id`, `entity.${propertyName}`])

	[AutocompleteType.AwardIssuer]: UserAwardExperience;
	[AutocompleteType.AwardIssuer]: Company;

+  /**
+   * A JSON object to store additional metadata or flags related to the user experience.
+   *
+   * This field is flexible and can store various key-value pairs. Examples of possible keys:
+   * - "isFeatured": A boolean indicating if the experience is featured.
+   * - "priority": A number representing the priority level of the experience.
+   * - "tags": An array of strings for categorization or tagging.
+   *
+   * Developers should ensure that the keys and values stored in this field are consistent
+   * with the application's requirements and properly validated before use.
+   */

feat: add user flags, profile experiences and autocomplete for profile interim #2944

Are you sure you want to change the base?

feat: add user flags, profile experiences and autocomplete for profile interim #2944

Conversation

ilasw commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira ticket

Uh oh!

pulumi bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resource Changes

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

capJavert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

capJavert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ilasw commented Jul 23, 2025 •

edited

Loading

pulumi bot commented Jul 23, 2025 •

edited

Loading