Skip to content

feat: support multiple file types for resume upload #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 24, 2025

Conversation

ilasw
Copy link
Contributor

@ilasw ilasw commented Jul 24, 2025

No description provided.

Copy link

pulumi bot commented Jul 24, 2025

🍹 The Update (preview) for dailydotdev/api/prod (at ee019f9) was successful.

Resource Changes

    Name                                            Type                           Operation
~   vpc-native-clean-zombie-images-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron     kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-calculate-top-readers-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-hourly-notification-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-bg-deployment                        kubernetes:apps/v1:Deployment  update
+   vpc-native-api-migration-1b4038f2               kubernetes:batch/v1:Job        create
~   vpc-native-update-source-public-threshold-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-tag-view-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-temporal-deployment                  kubernetes:apps/v1:Deployment  update
~   vpc-native-generate-search-invites-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-update-views-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-update-trending-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-validate-active-users-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-update-highlighted-views-cron        kubernetes:batch/v1:CronJob    update
-   vpc-native-api-migration-c900e06c               kubernetes:batch/v1:Job        delete
~   vpc-native-sync-subscription-with-cio-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-check-analytics-report-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tags-str-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-deployment       kubernetes:apps/v1:Deployment  update
~   vpc-native-private-deployment                   kubernetes:apps/v1:Deployment  update
~   vpc-native-daily-digest-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron   kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-recommendations-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-generic-referral-reminder-cron       kubernetes:batch/v1:CronJob    update
~   vpc-native-deployment                           kubernetes:apps/v1:Deployment  update
~   vpc-native-ws-deployment                        kubernetes:apps/v1:Deployment  update

@@ -8,6 +8,14 @@ import { logger } from '../logger';

export const RESUMES_BUCKET_NAME = 'daily-dev-resumes';

export const acceptedMimeTypes = [
'application/pdf',
'application/msword', // doc file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not need this now.

Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the doc support, then I think we should be good.

@ilasw ilasw marked this pull request as ready for review July 24, 2025 09:52
@ilasw ilasw requested review from capJavert and a team as code owners July 24, 2025 09:52
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugbot free trial expires on July 31, 2025
Learn more in the Cursor dashboard.

Comment bugbot run to trigger another review on this PR

Copy link
Contributor

@capJavert capJavert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few things to check, overall good to go!

@ilasw ilasw requested a review from capJavert July 24, 2025 10:34
@ilasw ilasw requested a review from capJavert July 24, 2025 11:04
@ilasw
Copy link
Contributor Author

ilasw commented Jul 24, 2025

bugbot run

@ilasw ilasw enabled auto-merge (squash) July 24, 2025 14:59
@ilasw ilasw merged commit 471d9ac into main Jul 24, 2025
9 checks passed
@ilasw ilasw deleted the feat-cv-doc-upload-support branch July 24, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants