Enable WebDAV properties to be set on calendars #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main exception is MutexGuard's held across .await points
…rning an Err in one case
…then deleting at sync time
RemoteCalendar remains unimplemented.
added 29 commits
September 5, 2024 14:26
…te for properties in RemoteCalendar
…bug. Now on to other bugs!
Reverts to using the prop value as the version tag, but does it everywhere
…transient; passing
We remove an assertion because it ignored that the calendar could be mocked to provide errors
This reverts commit 7c49178.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my use case I need to set metadata on the calendar collections themselves. To that end this PR enables arbitrary WebDAV properties to be set on calendars, using the same modify local / sync to remote paradigm as KF uses generally. Tests and mocking have been extended to check the main functionality. This is being used in my Hecho project.