Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't move windows when removing/adding monitors #817

Closed
7 tasks done
dalyIsaac opened this issue Jan 29, 2024 · 0 comments · Fixed by #824
Closed
7 tasks done

Don't move windows when removing/adding monitors #817

dalyIsaac opened this issue Jan 29, 2024 · 0 comments · Fixed by #824
Labels
bug Something isn't working core Whim

Comments

@dalyIsaac
Copy link
Owner

dalyIsaac commented Jan 29, 2024

When Windows removes a monitor, it will move windows. Based on that, Whim receives window added and window moved events.

Reproduction

Test by removing dock cable then plugging it in before Windows has a chance to reconcile.

Requirements

  • Windows do not all appear on the single monitor after repro steps
  • Layout is retained when restoring monitors

Proposed fix

  • Ignore events until after a timer triggered by a monitor change event
  • The timer will be reset by subsequent monitor change events
  • After the timer completes, do a complete layout

TODOs

  • Allow events for windows which aren't tracked
  • Manual tests
  • Tests
  • TODOs
  • Docs
@dalyIsaac dalyIsaac added this to Whim Jan 28, 2024
@dalyIsaac dalyIsaac converted this from a draft issue Jan 29, 2024
@dalyIsaac dalyIsaac added bug Something isn't working core Whim labels Jan 29, 2024
@dalyIsaac dalyIsaac changed the title Don't route already added windows in WindowManager_WindowAdded Don't move windows when removing/adding monitors Feb 3, 2024
@dalyIsaac dalyIsaac added the help wanted Extra attention is needed label Feb 3, 2024
@dalyIsaac dalyIsaac linked a pull request Feb 6, 2024 that will close this issue
@dalyIsaac dalyIsaac removed the help wanted Extra attention is needed label Feb 6, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Whim Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Whim
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant