-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try avoid moving windows when removing/adding monitors #824
Try avoid moving windows when removing/adding monitors #824
Conversation
Co-authored-by: github-actions <[email protected]>
Co-authored-by: github-actions <[email protected]>
…y-added-windows-in-windowmanager_windowadded
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
+ Coverage 81.27% 81.30% +0.03%
==========================================
Files 197 198 +1
Lines 10227 10212 -15
Branches 1142 1140 -2
==========================================
- Hits 8312 8303 -9
+ Misses 1790 1785 -5
+ Partials 125 124 -1 ☔ View full report in Codecov by Sentry. |
2d48e64
to
7f91bcc
Compare
When Windows removes/adds monitors, it will helpfully move windows to/from monitors. However, Whim is a window manager and we'd like to control this behavior.
To work around Windows' helpfulness, the
WindowManager
andButlerEventHandlers
ignore all Windows events for tracked windows. This has the downside of potentially missing a window closing, but I've judged that it's more important to keep windows in the correct workspaces.Other changes include:
AccessViolationException
in theBar