Fix monthly checks for UpdaterPlugin #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalyIsaac
force-pushed
the
fix-updater-max-interval
branch
from
36efa50 to
5dd4c0a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1063-provide-yaml-config-by-default #1065 +/- ##
======================================================================
Coverage ? 80.56%
======================================================================
Files ? 283
Lines ? 12408
Branches ? 1432
======================================================================
Hits ? 9997
Misses ? 2226
Partials ? 185 ☔ View full report in Codecov by Sentry. |
dalyIsaac
merged commit 2fadf98
into
1063-provide-yaml-config-by-default
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using a monthly check for updates would cause an integer overflow.
This was because of the maximum
dueDatein theTimerclass. This has been resolved by triggering the event daily and verify whether a check can occur on that date.