Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force double SetWindowPos for BarWindow #886

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Apr 30, 2024

It seems this is necessary for windows in monitors with 100% scaling. This will need further investigation in #887 for the difference in behavior between C# and what's fetched from the XAML.

@dalyIsaac dalyIsaac added bug Something isn't working bar Whim.Bar labels Apr 30, 2024
@dalyIsaac dalyIsaac linked an issue Apr 30, 2024 that may be closed by this pull request
@dalyIsaac dalyIsaac marked this pull request as ready for review April 30, 2024 11:39
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.47%. Comparing base (2062e05) to head (d5ecb94).

Files Patch % Lines
src/Whim.Bar/BarPlugin.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   81.46%   81.47%           
=======================================
  Files         199      199           
  Lines       10161    10165    +4     
  Branches     1141     1142    +1     
=======================================
+ Hits         8278     8282    +4     
  Misses       1767     1767           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac merged commit 19cf769 into main Apr 30, 2024
9 checks passed
@dalyIsaac dalyIsaac deleted the 884-bar-height-does-not-work branch April 30, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bar Whim.Bar bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar Height does not work
1 participant