Skip to content

Conversation

@jbicha
Copy link

@jbicha jbicha commented Dec 3, 2025

ansi-term appears to be unmaintained. Let's switch to the popular maintained fork, nu-ansi-term.

It explicitly adds the "bright" colors and a "default" color. I didn't know how to handle the default color at all and I took a guess at the bright colors. The bright colors are named as Light variants of the existing colors except that DarkGrey is the bright version of black.

My goal was to help one of the last things packaged in Debian using ansi-term to use nu-ansi-term instead.

@jbicha jbicha force-pushed the nu-ansi-term branch 2 times, most recently from c922601 to 1189f17 Compare December 4, 2025 14:12
@jbicha
Copy link
Author

jbicha commented Dec 4, 2025

I think some of the line breaks that cargo fmt wants aren't as useful for readability. Maybe we need to tweak the configuration or maybe you're happy with what it already recommends.

Feel free to fix this up however you want.

@th1000s
Copy link
Collaborator

th1000s commented Dec 9, 2025

Thank you.

I didn't know how to handle the default color at all and I took a guess at the bright colors.

Where did you have to handle those extra nu_ansi_term features? Most of the commit looks like straightforward search-and-replace.

Also, I'm thinking of internally re-exporting nu_ansi_term as crate::ansi::term in src/ansi/mod.rs to make the name a bit more brief, if you're ok with force-pushing that in your name. Maybe that also fixes the format issue - which file/line do mean?

@jbicha
Copy link
Author

jbicha commented Dec 12, 2025

I force-pushed an alternate way of keeping the shorter ansi_term name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants