-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add segment_ends
and Update morphology tips outputs
#1644
base: main
Are you sure you want to change the base?
Conversation
avoid saving to outputs in the helper function but produce the same relevant outputs, update instances of find_tips getting used throughout morphology
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
img input not just for plotting debug
add optimal assignment input
since no outputs in sorting, skip the label storage. wasn't used downstream but also don't need to store anymore since _find_tips also doesn't store to outputs
rearrage ome imports and change where things are getting called from
Jan 3 updates: the deepsource complaint about the complexity of While thinking about how to get biologically-ordered observations out from a morphology workflow given this new function, there is a reason to return a re-ordered list of objects. These can then get used downstream to get consistently labeled leaf segment observations. |
segment_ends
and Update morphology tips outputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the context is incomplete, just needs the end of that sentence about grass species.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, in the example usage there is a parenthesis missing, and I think the two segment_id examples are reversed? Should the "without id reassignment" example be with leaf_objs, not sorted_obs?
Describe your changes
_iterative_prune
into the_helper.py
file to avoid circular imports (this unfortunately touches most of the functions in this package)find_tips
(adds a helper function_find_tips
that is used internally by many functions and doesn't store outputs so they do not accidentally get overwritten)pcv.morphology.segment_ends
which saves both ends, the tip coordinates and the coordinates of the segment touching the branch point.Type of update
Is this a:
Associated issues
plantcv.morphology
sub-package #1643Additional context
tips
coordinates toOutputs
was easily overwritten by other morphology functions that utilize thepcv.morphology.find_tips
function.For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md