Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update closing.py #1669

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update closing.py #1669

wants to merge 2 commits into from

Conversation

eseigel
Copy link
Contributor

@eseigel eseigel commented Jan 31, 2025

Changed len(np.unique(gray_img)) to >2

Describe your changes
Changed len(np.unique(gray_img)) to >2, allowing all black or white images to be treated as binary.

Type of update
Is this a:
New feature or feature enhancement

Associated issues
#1635

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Changed len(np.unique(gray_img)) to >2
Copy link

deepsource-io bot commented Jan 31, 2025

Here's the code health analysis summary for commits 432fcd2..4eaefbd. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@eseigel eseigel added enhancement Enhancements to existing features ready to review labels Jan 31, 2025
@HaleySchuhl HaleySchuhl mentioned this pull request Jan 31, 2025
33 tasks
@HaleySchuhl HaleySchuhl self-requested a review February 21, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants