Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update web-vault to v2025.1.1 #189

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

stefan0xC
Copy link
Contributor

New web-vault release: web-v2025.1.1

@BlackDex
Copy link
Collaborator

There is a new Devices tab in the user settings.
That needs at least an endpoint for show the devices, and probably also some extra's to probably remove access.

I wanted to add something similar to the Vaultwarden Admin environment, but have not yet come around to do that.

@stefan0xC
Copy link
Contributor Author

Ah, cool. I've added the two endpoints: dani-garcia/vaultwarden#5422

@BlackDex BlackDex merged commit 2b56dc7 into dani-garcia:master Jan 22, 2025
1 check passed
@stefan0xC stefan0xC deleted the update-to-v2025.1.1 branch January 22, 2025 18:16
@tessus
Copy link
Contributor

tessus commented Jan 23, 2025

@BlackDex is it still necessary for the web vault to be marked as pre-release?

@BlackDex
Copy link
Collaborator

Yes, since there is no stable release yet of Vaultwarden it self which includes this version. This way we prevent users or packagers from trying to use a web-vault with an older release of Vaultwarden.

@tessus
Copy link
Contributor

tessus commented Jan 24, 2025

Hmm, I see. Thanks.

Although just as an info, packagers do not always package only releases. e.g. I create packages in the form x.y.z^YYYYMMDD.githash as well. So do a lot of others.

But you could make the mesaage a bit less restrictive:

DO NOT USE THIS WITH ANY STABLE OR LATEST VAULTWARDEN YET!

should rather be:

DO NOT USE THIS WITH ANY STABLE VAULTWARDEN YET!

@stefan0xC
Copy link
Contributor Author

stefan0xC commented Jan 24, 2025

If packagers want to ship a version based of Vaultwarden's main branch instead of waiting for a release they can do so. Not sure why this pre-release message of the web-vault has to be changed for that. I mean in Vaultwarden latest refers to the latest stable release, so changing it to your suggestion would be confusing, I think.

@tessus
Copy link
Contributor

tessus commented Jan 24, 2025

This message sounds like the web vault will destroy your data (YOU HAVE BEEN WARNED) if used with the testing branch.

Either way this sentence is ambiguous and ahould be clarified.

You might know that latest means the latest release in this project. For most people however latest means the latest code, which in turn means the most recent commit in the main/dev/master branch (whatever branch is used to cut releases).

So how about:

DO NOT USE THIS WITH THE LATEST RELEASE OF VAULTWARDEN YET!

@BlackDex
Copy link
Collaborator

We can discuss the terms latest, testing, beta, alpha etc... But there are more projects which use latest as just a tag for there stable releases, and beta or dev for there rolling releases.

For this projects, stable and latest are the same, and how do you know for sure it might not break your whole vault if using this newer version of the web-vault with an older Vaultwarden, it could be a possibility.

I'm going to convert it to release once there is a new version of Vaultwarden, not earlier, since we had reports in the past of people using newer web-vault's with older versions and then complaining stuff didn't worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants