ide: Use Spawner for updating registers, add delay #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently noticed that iPodLinux was struggling to boot due to the IDE IRQ handling being set right after sending IDE commands. This PR introduces a `task_spawner` member to IDE driver for deferring operation. It also adds basic implementations of Recal/ReadNativeMax. A significant amount of code is due to the use of Arc<RwLock<IdeRegs>> for thread safety. This PR allows iPodLinux hda initialization to go a little further, but work in ReadSectors still needs to be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently noticed that iPodLinux was struggling to boot due to the IDE IRQ handler being set right after sending IDE commands, causing the IDE IRQ to be not handled properly. A little delay and exposing register updates makes iPodLinux boot go a little further.
This PR introduces a
task_spawnermember to IDE driver for deferring operation. It also adds basic implementations of Recal/ReadNativeMax.A significant amount of code is due to the use of Arc<RwLock> for thread safety.
Work in ReadSectors still needs to be done to consider hda initialization in iPodLinux to be completely working.