Skip to content

Conversation

@vinceli1004
Copy link
Collaborator

@vinceli1004 vinceli1004 commented Apr 9, 2022

Done So Far:
famgraph::RemoteGraph::Iterator::FillWindow now takes a std::vector<famgraph::VertexRange> instead of a single famgraph::VertexRange .

For each VertexRange, a raddr and length are calculated and added to a std::vector<FAM::FamSegment>, which is used to call the vector version of FAM::FamControl::Read.

TODO:

  • famgraph::RemoteGraph::Iterator::Next() still passes in only a single VertexRange (a vector with size 1) to FillWindow()
    • famgraph::RemoteGraph::Iterator::MaximalRange should be made to return a std::vector<famgraph::VertexRange> of the VertexRanges that will fit into the window - capped at 40 (Note: Find the appropriate constant)
    • The return value from MaximalRange() should be passed into FillWindow() directly instead of being wrapped in a std::Vector
  • Additional state may need to be added to the iterator to keep track of all the windows in the current buffer. For example, if we load in the edges for [1,2,3] and [4,5,6] we need a way to say that once we reach the end of 3, not to use RDMA for more edges because we already have [4,5,6] in the local buffer.
  • Tests
    (Resolves Use vector overload of Read(), in RemoteGraph Iterator #16)

@vinceli1004 vinceli1004 added the enhancement New feature or request label Apr 9, 2022
@vinceli1004 vinceli1004 requested a review from danieldzahka April 9, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use vector overload of Read(), in RemoteGraph Iterator

3 participants