RemoteGraph Iterator Use vector read() #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done So Far:
famgraph::RemoteGraph::Iterator::FillWindownow takes astd::vector<famgraph::VertexRange>instead of a singlefamgraph::VertexRange.For each
VertexRange, araddrandlengthare calculated and added to astd::vector<FAM::FamSegment>, which is used to call the vector version ofFAM::FamControl::Read.TODO:
famgraph::RemoteGraph::Iterator::Next()still passes in only a single VertexRange (a vector with size 1) toFillWindow()famgraph::RemoteGraph::Iterator::MaximalRangeshould be made to return astd::vector<famgraph::VertexRange>of the VertexRanges that will fit into the window - capped at 40 (Note: Find the appropriate constant)MaximalRange()should be passed intoFillWindow()directly instead of being wrapped in astd::Vector(Resolves Use vector overload of Read(), in RemoteGraph Iterator #16)