Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several minor design changes and small edits. #1212

Closed
wants to merge 3 commits into from

Conversation

machinsoft
Copy link
Contributor

@machinsoft machinsoft commented Nov 23, 2023

A few minor design changes, I hope you like them. If not, I will remove the pull requests later, so take a look at how it looks and decide whether to accept it or not. It deviates a bit from the openai standard, but you can make your own changes later and modify some of the icons.

before
image
image

after

image
image

before
image
image
image

after
image
image
image
image

before
image

after
image

Pull Request Template

⚠️ Before Submitting a PR, read the Contributing Docs in full!

Summary

Please provide a brief summary of your changes and the related issue. Include any motivation and context that is relevant to your changes. If there are any dependencies necessary for your changes, please list them here.

Change Type

Please delete any irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)

Testing

Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.

Test Configuration:

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

A few minor design changes, I hope you like them. If not, I will remove the pull requests later, so take a look at how it looks and decide whether to accept it or not. It deviates a bit from the openai standard, but you can make your own changes later and modify some of the icons.
@danny-avila
Copy link
Owner

Thanks for your PR. some of these changes are good, but some are reverting back to the old style which I dont think I can merge.

With UI changes, before and after screenshots are helpful to better gauge the changes.

@machinsoft
Copy link
Contributor Author

machinsoft commented Nov 23, 2023

I added more pictures, before and after

@machinsoft
Copy link
Contributor Author

Thanks for your PR. some of these changes are good, but some are reverting back to the old style which I dont think I can merge.

With UI changes, before and after screenshots are helpful to better gauge the changes.

I returned closer to the OpenAI design standard and updated the images again. :)

@mmw1984
Copy link

mmw1984 commented Nov 24, 2023

IMG_1229
IMG_1228

Little compare to official and LibreChat now…
Although it is nearly the same
BUT
The update is actually great!

@mmw1984
Copy link

mmw1984 commented Nov 24, 2023

Btw, the side bar….

@mmw1984
Copy link

mmw1984 commented Nov 24, 2023

Btw, the sidebar too…
And some improvements can be added to the home page?
IMG_1230

The “ How can I help you today?” can be changed to Hello, {titlename}. Same to the one above.

@machinsoft
Copy link
Contributor Author

If you don't like some of the changes, you can take a part of them, add them to your branch, and create a new pull request. I will delete my pull request, and it's not a big deal if you copy someone else's branch. Personally, I don't care whether it gets approved or not, but it can't linger for too long. I will need to propose other changes, and this pull request will be in the way.

I also prefer square avatars, so most likely, on my website, I will use square avatars instead of round ones.

@machinsoft
Copy link
Contributor Author

image
There are still situations I haven't figured out how to resolve, so that invisible icons don't take up space

@danny-avila
Copy link
Owner

Make a new PR just for the login/registration views, I will only merge those changes

@machinsoft machinsoft deleted the machine branch November 24, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants