🔥 feat: deepseek-reasoner Thought Streaming
#5379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing in OpenAIClient
… 0, flag for legacy behavior
1 task
owengo
pushed a commit
to openwengo/LibreChat
that referenced
this pull request
Jan 21, 2025
* 🔧 refactor: Remove unused penalties and enhance reasoning token handling in OpenAIClient * 🔧 refactor: `addInstructions` default to adding instructions at index 0, flag for legacy behavior * chore: remove long placeholder * chore: update localization strings across multiple languages * ci: adjust tests for new `addInstructions` behavior
lpirola
pushed a commit
to lpirola/LibreChat
that referenced
this pull request
Jan 22, 2025
* 🔧 refactor: Remove unused penalties and enhance reasoning token handling in OpenAIClient * 🔧 refactor: `addInstructions` default to adding instructions at index 0, flag for legacy behavior * chore: remove long placeholder * chore: update localization strings across multiple languages * ci: adjust tests for new `addInstructions` behavior
justinmdickey
pushed a commit
to e-gineering/LibreChat
that referenced
this pull request
Jan 30, 2025
* 🔧 refactor: Remove unused penalties and enhance reasoning token handling in OpenAIClient * 🔧 refactor: `addInstructions` default to adding instructions at index 0, flag for legacy behavior * chore: remove long placeholder * chore: update localization strings across multiple languages * ci: adjust tests for new `addInstructions` behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5377
I introduced fixes necessary to support deepseek-reasoner thought streaming, updated localization strings across multiple languages, removed a long placeholder, and refactored message handling in the BaseClient and OpenAIClient files. I added a default behavior to addInstructions that places instructions at index 0, and I removed unused penalties while enhancing reasoning token handling.
Note: this does not cover thought streaming when using Agents
Change Type
Testing
I tested by running local builds of the client and verifying that the new localization strings rendered correctly. I also tested text streaming logic in conjunction with deepseek reasoning streams to ensure tokens were handled properly. I recommend running local tests with various models to confirm CoT tokens appear as expected.
Checklist