Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 feat: Artifact Editing & Downloads #5428

Merged
merged 13 commits into from
Jan 23, 2025
Merged

🚀 feat: Artifact Editing & Downloads #5428

merged 13 commits into from
Jan 23, 2025

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Jan 23, 2025 •
edited
Loading

Summary

I consolidated various fixes and feature improvements focusing on reliable artifact editing

  • Refactored artifact editing UX, adding a code editor for artifacts and handling optimistic updates
  • Implemented robust artifact content replacement on the server, ensuring no conflicts when changing shared artifact data.
  • Added a dedicated download button to retrieve artifact content and added scroll behavior to new code editor.

Closes #4645

Other Changes

  • Handle edge cases for Assistants API in StreamRunManager by adding default messages and improved logging for undefined tool outputs.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes

@danny-avila danny-avila mentioned this pull request Jan 23, 2025
Closed
8 tasks
@danny-avila danny-avila changed the title 🚀 feat: Enhanced Artifact Editing & UI 🚀 feat: Artifact Editing & Downloads Jan 23, 2025
@danny-avila danny-avila merged commit ed57bb4 into main Jan 23, 2025
4 checks passed
@danny-avila danny-avila deleted the feat/artifacts-edit branch January 23, 2025 23:19
justinmdickey pushed a commit to e-gineering/LibreChat that referenced this pull request Jan 30, 2025
@danny-avila @justinmdickey
🚀 feat: Artifact Editing & Downloads (danny-avila#5428)
5e82d7f 
* refactor: expand container

* chore: bump @codesandbox/sandpack-react to latest

* WIP: first pass, show editor

* feat: implement ArtifactCodeEditor and ArtifactTabs components for enhanced artifact management

* refactor: fileKey

* refactor: auto scrolling code editor and add messageId to artifact

* feat: first pass, editing artifact

* feat: first pass, robust artifact replacement

* fix: robust artifact replacement & re-render when expected

* feat: Download Artifacts

* refactor: improve artifact editing UX

* fix: layout shift of new download button

* fix: enhance missing output checks and logging in StreamRunManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: artifacts - add button to download/save the generated html (or other code)
1 participant
@danny-avila