Skip to content

🔐 feat/passkey #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Conversation

rubentalstra
Copy link
Collaborator

@rubentalstra rubentalstra commented Jan 27, 2025

Summary

it works. but I need to clean up this request before it is even merge able.

Change Type

Please delete any irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Translation update

Testing

Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.

Test Configuration:

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

Closes: danny-avila#3438

TODO:
- write config Doc
Introduce comprehensive tests for the Apple login strategy, covering new user creation, existing user updates, and error handling scenarios during the authentication flow. Mocks implemented for external dependencies to ensure isolated testing.
This commit introduces Passkey (WebAuthn) authentication using the `passport-fido2-webauthn` library. It includes API routes for registration and login, integration in the frontend UI, and configuration updates for enabling passkey authentication. Additional dependencies required for WebAuthn are added.
Replaced obsolete passkey routes with new `authPasskey` routes for FIDO2 WebAuthn support. Updated client and server configurations to integrate passkey strategies, sessions, and dependencies (`@simplewebauthn` and related libraries).
This commit removes the Apple login functionality, including related strategies, routes, tests, and dependencies.
@rubentalstra rubentalstra changed the title Feat/passkey 🔐 feat/passkey Jan 28, 2025
@rubentalstra
Copy link
Collaborator Author

https://www.npmjs.com/package/passport-simple-webauthn2
https://github.com/rubentalstra/passport-simple-webauthn2

finally created a working package to implement as a passport Strategy. (this was non-existing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant