hevm: london hard fork #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-xo
reviewed
Jul 3, 2021
| @@ -19,7 +19,7 @@ let | |||
| export PATH=${x.pkgs.hevm}/bin:${x.pkgs.jq}/bin:$PATH | |||
| ${x.pkgs.hevm}/bin/hevm compliance \ | |||
| --tests ${ethereum-test-suite x} \ | |||
| --skip "(Create2Recursive|Create1000|recursiveCreateReturn|underflowTest|walletRemoveOwnerRemovePending|Return5000|randomStatetest177|loopExp|loopMul)" \ | |||
| --skip "(Create2Recursive|Create1000|recursiveCreateReturn|underflowTest|walletRemoveOwnerRemovePending|Return5000|randomStatetest177|loopExp|loopMul|FirstByte)" \ | |||
There was a problem hiding this comment.
why are we skipping FirstByte?
There was a problem hiding this comment.
Those tests do not have a poststate, just the poststate hash, which we are not deciphering at the moment
There was a problem hiding this comment.
can we document that as a comment in this file? Would be awesome to have reasons for all the skips here actually, but that doesn't have to be done now.
d-xo
reviewed
Jul 3, 2021
|
Do we handle the ropsten issue (https://notes.ethereum.org/@timbeiko/ropsten-postmortem) correctly? I can't figure it out from a quick scan of the code... |
MrChico
force-pushed
the
london
branch
2 times, most recently
from
7cc8b6e to
dda254b
Compare
MrChico
commented
Jul 29, 2021
MrChico
commented
Jul 29, 2021
|
The seth helpers can be implemented in another pr. I think this is ready for review if ci passes |
d-xo
reviewed
Aug 5, 2021
MrChico
commented
Aug 5, 2021
MrChico
commented
Aug 5, 2021
MrChico
commented
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to update the seth and dapp tooling, but here are the consensus changes