-
Notifications
You must be signed in to change notification settings - Fork 203
feat: Allow configuring the scheduler host on init #1520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yaron2
merged 3 commits into
dapr:master
from
acroca:set-scheduler-binding-address-on-init
Jul 15, 2025
Merged
feat: Allow configuring the scheduler host on init #1520
yaron2
merged 3 commits into
dapr:master
from
acroca:set-scheduler-binding-address-on-init
Jul 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Callarisa <[email protected]>
JoshVanL
previously approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also backport this to release-1.15 and create a patch release.
Signed-off-by: Albert Callarisa <[email protected]>
5263b25
to
847ed81
Compare
Signed-off-by: Albert Callarisa <[email protected]>
72d8a7c
to
d4731e5
Compare
Patch PR here: #1521 |
@acroca tests are failing |
@acroca - Please raise a PR for Dapr docs. |
7 tasks
@msfussell Thanks for reminding updating the docs :) dapr/docs#4721 |
cicoyle
approved these changes
Jul 14, 2025
yaron2
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new flag for
dapr init
where the user can specify the scheduler host.This allows running dapr apps pointing to a remote scheduler, as long as the configured scheduler host address is reachable from the dapr app.
To test this feature, I have a container with
dind
anddapr
, where I executed:Then from another container with access to the docker instance from dind, I'm running a service with:
dapr run --app-id=test \ --metrics-port=9091 \ --scheduler-host-address=dind-service:50006 \ --placement-host-address=dind-service:50005 \ --dapr-grpc-port 50001 \ --app-port 50070 \ --app-protocol grpc \ --log-level debug \ go run .
With this change, I see the following logs:
Without this change, it failed:
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1518
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: