Skip to content

Added .NET SDK examples to serialization document #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 23, 2025

Conversation

WhitWaldo
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

The SDK serialization page claimed that only Java uses JSON serialization. To my knowledge, that's not accurate at all - all of the languages use JSON, though there have been recent requests for other serialization approaches. Regardless... while supposedly addressing serialization requirements across the solution, it only provided Java-specific examples. This PR adds .NET examples that are current (for now) to the 1.16 release.

Issue reference

Please reference the issue this PR will close: #4595

@WhitWaldo WhitWaldo self-assigned this Mar 22, 2025
@WhitWaldo WhitWaldo requested review from a team as code owners March 22, 2025 23:59
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Mar 28, 2025
@WhitWaldo WhitWaldo removed the stale label Mar 28, 2025
Copy link

github-actions bot commented Apr 3, 2025

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 3, 2025
@WhitWaldo WhitWaldo removed the stale label Apr 3, 2025
Copy link

github-actions bot commented Apr 9, 2025

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 9, 2025
@WhitWaldo WhitWaldo removed the stale label Apr 9, 2025
@WhitWaldo
Copy link
Contributor Author

@alicejgibbons Any chance you could review this?

Updated formatting and grammar

Signed-off-by: Mark Fussell <[email protected]>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will also let @alicejgibbons comment

Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Whit, big improvement but just a couple small things.

{{% /codetab %}}

<!-- Java -->
{{% codetab %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't think that this invokeActorMethod is correct anymore (unless you're using springboot?). @cicoyle can you take a peek at this actors example?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out - If Whit has the bandwidth and would like to update the Java code samples that would be great, but given this PR is for .NET, Im fine with proceeding with this PR and opening follow up issues to ensure the java sdk docs are up to date. I think that would be the best path forward to ensure proper prioritization of the work and not halt this PR that is updating .Net. We should definitely update the Java SDK documentation to align more clearly with our working examples in DemoActorClient.java and ActorTurnBasedConcurrencyIT.java.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, one thing I don't have is much bandwidth. I've never used the Java SDK and it seems to be receiving quite a few updates based on the flurry of PR notifications I've been receiving.

I would prefer to merge as-is if that's acceptable. I noticed while browsing around the other day that there are several other examples across the docs that I want to update (both for .NET and add JS samples throughout), so this is going to be far from the first of these.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WhitWaldo and others added 8 commits April 18, 2025 18:07
…sdk-serialization.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…sdk-serialization.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…sdk-serialization.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…sdk-serialization.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…sdk-serialization.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…sdk-serialization.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
WhitWaldo and others added 2 commits April 18, 2025 19:10
…sdk-serialization.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…sdk-serialization.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize that this PR is intended to update the .NET docs, but can we please at a minimum take the client.invokeMethod code suggestion in with this PR?

We can open follow up issues for the other mentioned java docs getting updated to not halt this PR for something its not intending to add.

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@msfussell msfussell merged commit 101b026 into dapr:v1.15 Apr 23, 2025
7 checks passed
@WhitWaldo WhitWaldo deleted the serialization-update branch April 24, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK serialization should be more generic
4 participants